Skip to content

docs: COR-102 - Interpolation for circle & ellipse objects [SDK]#1094

Closed
srikar-yantrapragada-encord wants to merge 1 commit into
masterfrom
srikar/cor-102-circle-ellipse-interpolation
Closed

docs: COR-102 - Interpolation for circle & ellipse objects [SDK]#1094
srikar-yantrapragada-encord wants to merge 1 commit into
masterfrom
srikar/cor-102-circle-ellipse-interpolation

Conversation

@srikar-yantrapragada-encord

Copy link
Copy Markdown

Linear: COR-102

Summary

One-line docstring update on Project.object_interpolation to mention circle and ellipse as supported shapes.

Why doc-only

Project.object_interpolation is shape-agnostic — it forwards key_frames + object_hashes straight to the backend's public-interpolation endpoint, which dispatches per-shape. The companion cord-backend PR (feat: COR-102 - Interpolation for circle & ellipse objects) adds the dispatch; no SDK code change is needed.

SDK label-model support for Shape.ELLIPSE / EllipseCoordinates (the encord.objects type system) is unrelated and out of scope.

Test plan

  • ruff check encord/project.py — passes.
  • Pre-existing ruff format --check finding at encord/project.py:227 (multi-line assert) is unrelated and intentionally untouched.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the docstring of the object_interpolation method in encord/project.py to document that object interpolation is now supported for circle and ellipse shapes, in addition to bounding boxes, polygons, and keypoints. There are no review comments, and I have no additional feedback to provide.

@github-actions

Copy link
Copy Markdown
Contributor

Unit test report (Python 3.9.24, Pydantic 2.12.3)

580 tests   580 ✅  15s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit fa895ea.

@github-actions

Copy link
Copy Markdown
Contributor

Unit test report (Python 3.9.24, Pydantic 1.10.22)

580 tests   580 ✅  12s ⏱️
  1 suites    0 💤
  1 files      0 ❌

Results for commit fa895ea.

@srikar-yantrapragada-encord srikar-yantrapragada-encord changed the title docs: COR-102 - Interpolation for circle & ellipse objects docs: COR-102 - Interpolation for circle & ellipse objects [SDK] May 29, 2026
Comment thread encord/project.py
"""Run object interpolation algorithm on project labels (requires an editor ontology and feature uids).

Interpolation is supported for bounding box, polygon, and keypoint.
Interpolation is supported for bounding box, polygon, keypoint, circle and ellipse.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this exhaustive? aren't all shapes supported?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i missed that - yes, all shapes are supported.

@srikar-yantrapragada-encord srikar-yantrapragada-encord deleted the srikar/cor-102-circle-ellipse-interpolation branch May 29, 2026 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants