This repository was archived by the owner on Feb 23, 2026. It is now read-only.
Regression in adonis4.x in passing properties to middleware fixes #22#23
Open
erikkallen wants to merge 2 commits intoenniel:masterfrom
Open
Regression in adonis4.x in passing properties to middleware fixes #22#23erikkallen wants to merge 2 commits intoenniel:masterfrom
erikkallen wants to merge 2 commits intoenniel:masterfrom
Conversation
cmelgarejo
approved these changes
Sep 5, 2018
cmelgarejo
left a comment
cmelgarejo
left a comment
There was a problem hiding this comment.
I had the same issue, awesome @erikkallen 👍
cmelgarejo
suggested changes
Sep 5, 2018
cmelgarejo
left a comment
cmelgarejo
left a comment
There was a problem hiding this comment.
Actually after trying again, you just have to use or and and instead of || and && in the expressions, no need to do another replacement! 😮
Just change the readme! (or just remove the commas and replace with spaces 😄 )
Author
|
@cmelgarejo you are right that looks a lot better too! I have updated the readme. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my current workaround the syntax might not be as pretty but is does work let me know if this is a viable option