Skip to content

Sign user out on unrecoverable error#14544

Open
somebody1234 wants to merge 9 commits intodevelopfrom
wip/sb/better-error-recovery
Open

Sign user out on unrecoverable error#14544
somebody1234 wants to merge 9 commits intodevelopfrom
wip/sb/better-error-recovery

Conversation

@somebody1234
Copy link
Copy Markdown
Contributor

@somebody1234 somebody1234 commented Dec 30, 2025

Pull Request Description

  • Fix https://github.com/enso-org/cloud-v2/issues/2287
    • Add an ErrorBoundary to Page that logs the user out
    • It cannot be at the top level (App/ReactRoot) as the router is inaccessible there.
    • All other ErrorBoundaries are fine, either:
      • in modal generic components (Dialog, Popover, Stepper)
      • in modal components (the components in the right sidebar, and specific tabs)

Important Notes

None

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@somebody1234 somebody1234 added the CI: No changelog needed Do not require a changelog entry for this PR. label Dec 30, 2025
@somebody1234 somebody1234 changed the title Wip/sb/better error recovery Sign user out on unrecoverable error Dec 30, 2025
@PabloBuchu
Copy link
Copy Markdown
Contributor

There is now a way to leak hybrid projects outside the account. We do not clear the project view or opened projects on 403 status code. This seems like a bug in general. With this error handling it easier to reproduce it just put thow Error in Settings.tsx

Screen.Recording.2026-01-05.at.14.06.55.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

--bug Type: bug CI: No changelog needed Do not require a changelog entry for this PR. g-dashboard

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants