Add more columns to dashboard asset table#14886
Conversation
PabloBuchu
requested review from
AdRiley,
farmaazon,
jdunkerley,
kazcw and
vitvakatu
as code owners
vitvakatu
left a comment
vitvakatu
left a comment
There was a problem hiding this comment.
Local is working, cloud is displaying error when I try to switch to it:
| /** A function to format given bytes into human readable string. */ | ||
| export function formatBytes(bytes?: number, decimals = 2) { | ||
| if (!bytes) return '' | ||
| if (!+bytes) return '0 Bytes' |
There was a problem hiding this comment.
I always advocate for not using ! operator with numeric types (and in a lot of cases, with any non-boolean types). In this particular case, the first check will trigger for 0 bytes, resulting in an empty string.
| </td> | ||
| </tr> | ||
| )} | ||
| <tr data-testid="asset-panel-created-by" className="h-row"> |
There was a problem hiding this comment.
This column is always rendered, despite the check in columnUtils that it should be visible for Team plans only.
| ) | ||
| break | ||
| } | ||
| case 'createdAt': { |
There was a problem hiding this comment.
createdAt filtering is not working for me. Neither does modified, btw.
CleanShot.2026-03-18.at.16.38.41.mp4
There was a problem hiding this comment.
fixed modification date. we wont support creation for now
PabloBuchu
added
the
CI: No changelog needed
|
I don’t see any changes since last review. Cloud still errors for me (#14886 (review)) and createdAt / modified still does not work (#14886 (comment)). Am I doing something incorrectly, @PabloBuchu ? |
|
After more careful testing (I had to clean local storage), I no longer see error when switching to cloud, but modified/createdAt search suggestions are still not working: CleanShot.2026-04-03.at.16.15.34.mp4Also, why don’t we allow sorting by size? Seems like useful operation. |
|
I did minor fixes, didn’t touch search functionality as it works weirdly at the moment and the code is quite complicated there, I don’t want to break it. Also changed icon for @farmaazon ready for review. |
3 participants
Pull Request Description
created atcolumn both to cloud and localsizecolumn with human readable size format for projects and filescreated bycolumn with component borrowed from shared with which displays original asset authorImportant Notes
Checklist
Please ensure that the following checklist has been satisfied before submitting the PR:
Scala,
Java,
TypeScript,
and
Rust
style guides. In case you are using a language not listed above, follow the Rust style guide.
or the Snowflake database integration, a run of the Extra Tests has been scheduled.