Skip to content

Move components when resizing viz#14904

Open
kazcw wants to merge 9 commits intodevelopfrom
wip/kw/resize-pushing
Open

Move components when resizing viz#14904
kazcw wants to merge 9 commits intodevelopfrom
wip/kw/resize-pushing

Conversation

@kazcw
Copy link
Copy Markdown
Contributor

@kazcw kazcw commented Mar 25, 2026

Move components when resizing viz

Screen.Recording.2026-03-25.at.06.52.22.mov

Fixes #14586.

Also fix node/visualization size consistency when viz size is reduced below its minimum.

Pull Request Description

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.
    • If applicable, it is suggested to paste a link to a successful run of the Extra Tests.

@kazcw kazcw self-assigned this Mar 25, 2026
@kazcw kazcw marked this pull request as ready for review March 25, 2026 14:32
Comment thread app/gui/src/project-view/components/GraphEditor/GraphNode.vue
Comment thread app/gui/src/project-view/components/GraphEditor/GraphNode.vue Outdated
Comment thread app/gui/src/project-view/components/GraphEditor/GraphNode.vue
Comment thread app/gui/src/project-view/components/GraphEditor/nodesDisplacing.ts Outdated
Comment thread app/gui/src/project-view/components/GraphEditor/nodesDisplacing.ts Outdated
Comment thread app/gui/src/project-view/components/GraphEditor/nodesDisplacing.ts Outdated
Comment thread app/gui/src/project-view/components/GraphEditor/nodesDisplacing.ts Outdated
Comment thread app/gui/src/project-view/components/GraphEditor/nodesDisplacing.ts
}
const bounds0 = Quad.fromRect(rect0)
const bounds1 = Quad.fromRect(rect1)
const pushStart = lastPushStart.value?.[0] === resizedId ? lastPushStart.value?.[1] : undefined
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do I read it correctly, that expanding and shrinking same node will always push nodes on expand, but pull back on shrink only if no other node was resized in the meantime?

@kazcw kazcw marked this pull request as draft March 26, 2026 14:24
@kazcw kazcw marked this pull request as ready for review April 3, 2026 14:00
@farmaazon farmaazon self-requested a review April 9, 2026 07:39
Copy link
Copy Markdown
Contributor

@farmaazon farmaazon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CR: ok

@kazcw kazcw added the CI: Ready to merge This PR is eligible for automatic merge label Apr 10, 2026
@jdunkerley jdunkerley modified the milestones: 2026.1 Release, 2025.3.2 Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

CI: Ready to merge This PR is eligible for automatic merge

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Moving components when opening/resizing/closing viz (to right and down components)

3 participants