Skip to content

Add trim methods#14982

Open
AdRiley wants to merge 6 commits intodevelopfrom
wip/adr/add-trim-methods
Open

Add trim methods#14982
AdRiley wants to merge 6 commits intodevelopfrom
wip/adr/add-trim-methods

Conversation

@AdRiley
Copy link
Copy Markdown
Member

@AdRiley AdRiley commented Apr 23, 2026

Pull Request Description

Adds Text_Column trim methods

Important Notes

Checklist

Please ensure that the following checklist has been satisfied before submitting the PR:

  • The documentation has been updated, if necessary.
  • Screenshots/screencasts have been attached, if there are any visual changes. For interactive or animated visual changes, a screencast is preferred.
  • All code follows the
    Scala,
    Java,
    TypeScript,
    and
    Rust
    style guides. In case you are using a language not listed above, follow the Rust style guide.
  • Unit tests have been written where possible.
  • If meaningful changes were made to logic or tests affecting Enso Cloud integration in the libraries,
    or the Snowflake database integration, a run of the Extra Tests has been scheduled.

@github-actions github-actions Bot added the -libs-API-change-Table Marks a PR that changes the public API of Standard.Table label Apr 28, 2026
@AdRiley AdRiley added the CI: Clean build required CI runners will be cleaned before and after this PR is built. label Apr 28, 2026
@AdRiley AdRiley force-pushed the wip/adr/add-trim-methods branch from 93d4c64 to 8961494 Compare April 29, 2026 07:40
@AdRiley AdRiley marked this pull request as ready for review April 29, 2026 08:21
Copy link
Copy Markdown
Member

@JaroslavTulach JaroslavTulach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest to follow the arguments in signature of Text.trim unless there is a justified reason why invent something else.

- reverse self -> (Standard.Table.Column.Column&Standard.Table.Refined_Types.Text_Column.Text_Column)
- right self n:(Standard.Table.Column.Column|Standard.Base.Data.Numbers.Integer|Standard.Base.Nothing.Nothing)= -> (Standard.Table.Column.Column&Standard.Table.Refined_Types.Text_Column.Text_Column)
- to_case self case_option:Standard.Base.Data.Text.Case.Case= locale:Standard.Base.Data.Locale.Locale= -> (Standard.Table.Column.Column&Standard.Table.Refined_Types.Text_Column.Text_Column)
- trim self what:(Standard.Table.Column.Column|Standard.Base.Data.Text.Text|Standard.Base.Any.Any)= where:Standard.Base.Data.Text.Location.Location= -> (Standard.Table.Column.Column&Standard.Table.Refined_Types.Text_Column.Text_Column)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • why do we create three methods here?
  • Can't we follow the signature of Text.trim
  • e.g. have just a single method
  • and where:Standard.Base.Data.Text.Location.Location argument defaulted to Both?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

-libs-API-change-Table Marks a PR that changes the public API of Standard.Table CI: Clean build required CI runners will be cleaned before and after this PR is built.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants