Skip to content

ESB-1208 - FIX: NPE on contentId during bundle installation when workflow plugin is enabled #360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
ffalqui wants to merge 1 commit into
base: develop
Choose a base branch
from
+4 −1
Open

ESB-1208 - FIX: NPE on contentId during bundle installation when workflow plugin is enabled #360

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 4 additions & 1 deletion ...letec/plugins/jpcontentworkflow/aps/system/services/notifier/WorkflowNotifierManager.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,7 +113,10 @@ public void listenContentSaving(ProceedingJoinPoint pjp, Object content) {
String contentId = currentContent.getId();
if (null != contentId) {
Content previousContent = this.getContentManager().loadContent(contentId, false);
if (previousContent.getStatus().equals(currentContent.getStatus())) {
// previousContent is null when the content is being created with a caller-supplied id
// (e.g. a bundle install that preserves content ids): there is no prior work copy to
// compare against, so it IS a status change — keep notify = true rather than NPE.
if (previousContent != null && previousContent.getStatus().equals(currentContent.getStatus())) {
notify = false;
}
}
Expand Down
Loading