Skip to content

[web][memories] update meta image and loading logics #9951

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AswinAsok merged 3 commits into from
Apr 7, 2026
Merged

[web][memories] update meta image and loading logics #9951

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c2fbd2e
update-meta
AswinAsok Apr 6, 2026
266b7f4
refractor(memories):update-logics-for-fetching
AswinAsok Apr 7, 2026
8b5df48
minor-ux-updations
AswinAsok Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
21 changes: 4 additions & 17 deletions web/apps/memories/src/components/PublicMemoryPageShell.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,31 +5,18 @@
*/
import { CircularProgress, Typography } from "@mui/material";
import { Stack100vhCenter } from "ente-base/components/containers";
import { CustomHead } from "ente-base/components/Head";
import { memoriesAppOrigin } from "ente-base/origins";
import Head from "next/head";
import type { PropsWithChildren } from "react";

/**
* Injects shared metadata for every public memory page.
* Injects page-specific metadata for every public memory page.
* Used only by `PublicMemoryPageShell` in this file.
*/
function PublicMemoryDocumentHead() {
const previewImage = `${memoriesAppOrigin()}/images/memories-meta.png`;

return (
<>
<CustomHead title="Ente Memories" />
<Head>
<meta name="robots" content="noindex, nofollow" />
<meta property="og:image" content={previewImage} />
<meta property="og:image:secure_url" content={previewImage} />
<meta property="og:image:type" content="image/png" />
<meta property="og:image:width" content="720" />
<meta property="og:image:height" content="405" />
<meta name="twitter:image" content={previewImage} />
</Head>
</>
<Head>
<meta name="robots" content="noindex, nofollow" />
</Head>
);
}

Expand Down
23 changes: 21 additions & 2 deletions web/apps/memories/src/pages/_app.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,14 +2,33 @@ import "@fontsource-variable/inter";
import "@fontsource/itim";
import { CssBaseline, GlobalStyles } from "@mui/material";
import { ThemeProvider } from "@mui/material/styles";
import { staticAppTitle } from "ente-base/app";
import { CustomHead } from "ente-base/components/Head";
import { useSetupLogs } from "ente-base/components/utils/hooks-app";
import { shareTheme } from "ente-base/components/utils/theme";
import type { AppProps } from "next/app";
import Head from "next/head";
import React from "react";

const memoriesAppStyle = { "--font-itim": "'Itim'" } as React.CSSProperties;
const memoriesAppTitle = "Ente Memories";

function MemoriesAppHead() {
const previewImage = "https://memories.ente.io/images/memories-meta.png";

return (
<>
<CustomHead title={memoriesAppTitle} />
<Head>
<meta property="og:image" content={previewImage} />
<meta property="og:image:secure_url" content={previewImage} />
<meta property="og:image:type" content="image/png" />
<meta property="og:image:width" content="720" />
<meta property="og:image:height" content="405" />
<meta name="twitter:image" content={previewImage} />
</Head>
</>
);
}

const App: React.FC<AppProps> = ({ Component, pageProps }) => {
useSetupLogs({ disableDiskLogs: true });
Expand All @@ -22,7 +41,7 @@ const App: React.FC<AppProps> = ({ Component, pageProps }) => {
// Avoid persisting a manual override; always follow the system theme.
storageManager={null}
>
<CustomHead title={staticAppTitle} />
<MemoriesAppHead />
<CssBaseline enableColorScheme />
<GlobalStyles
styles={{
Expand Down
Loading