Skip to content

fix: add PR number context to file-content fetch failure warning#711

Merged
anderdc merged 3 commits intoentrius:testfrom
MkDev11:fix/issue-github-pr-file-content-fetch-failure
Apr 23, 2026
Merged

fix: add PR number context to file-content fetch failure warning#711
anderdc merged 3 commits intoentrius:testfrom
MkDev11:fix/issue-github-pr-file-content-fetch-failure

Conversation

@MkDev11
Copy link
Copy Markdown
Contributor

@MkDev11 MkDev11 commented Apr 22, 2026

Summary

  • Adds optional pr_number context to the existing warning in _fetch_file_contents_with_base_batch when file-content GraphQL fetch returns None.
  • Threads pr.number from scoring into fetch_file_contents_with_base(...) so logs identify the exact failed PR.
  • Keeps behavior intentionally unchanged:
    • no tuple-return API changes
    • no skip-vs-zero branching changes
    • no None vs [] return-contract changes
    • no new test file
  • Net diff is minimal (13 lines total: +10 / -3 across 2 files).

Related Issues

Closes #710
Supersedes #645

Type of Change

  • Bug fix
  • New feature
  • Refactor
  • Documentation
  • Other (describe below)

Testing

  • Tests added/updated

  • Manually tested

  • Ran:

    • uv run pytest tests/utils/test_github_api_tools.py tests/validator/test_base_score.py
  • Result:

    • 82 passed

Checklist

  • Code follows project style guidelines
  • Self-review completed
  • Changes are documented (if applicable)

@xiao-xiao-mao xiao-xiao-mao Bot added the bug Something isn't working label Apr 22, 2026
@anderdc anderdc added enhancement New feature or request and removed bug Something isn't working labels Apr 23, 2026
@anderdc anderdc merged commit 61f7fc8 into entrius:test Apr 23, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] file-content fetch failure logs omit PR number, making failed PR untraceable

2 participants