Rename BoxedRound::new_dynamic to just new - #112
Closed
dvdplm wants to merge 2 commits into
Closed
Conversation
Pull Request Test Coverage Report for Build 15269611379Details
💛 - Coveralls |
Contributor
|
Yeah, perhaps. It was a preparation for #65 which I'm not sure is coming |
dvdplm
force-pushed
the
dp-rename-new_dynamic
branch
from
May 27, 2025 07:49
a1e55d1 to
2b8c678
Compare
There was a problem hiding this comment.
Pull Request Overview
This PR renames the BoxedRound::new_dynamic constructor to the shorter BoxedRound::new, updating its definition, all call sites, and the changelog.
- Renamed the constructor in
boxed_round.rs - Updated every
new_dynamiccall tonewacross tests, benches, session code, combinators, and examples - Added a changelog entry for this API change
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| manul/src/tests/partial_echo.rs | Updated call from new_dynamic to new |
| manul/src/session/session.rs | Updated call from new_dynamic to new |
| manul/src/protocol/boxed_round.rs | Renamed new_dynamic method to new |
| manul/src/combinators/misbehave.rs | Updated calls from new_dynamic to new |
| manul/src/combinators/chain.rs | Updated calls from new_dynamic to new |
| manul/benches/empty_rounds.rs | Updated calls from new_dynamic to new |
| manul/benches/async_session.rs | Updated calls from new_dynamic to new |
| examples/src/simple.rs | Updated calls from new_dynamic to new |
| CHANGELOG.md | Added entry for new_dynamic → new rename |
Contributor
|
If we decide to go with #117, it will invalidate this PR. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Given that there are no other constructors available on
BoxedRoundI think it's better to name it justnew.