Skip to content

Fix build warnings - #125

Merged
fjarri merged 2 commits into
entropyxyz:masterfrom
fjarri:fix-build
Sep 19, 2025
Merged

Fix build warnings#125
fjarri merged 2 commits into
entropyxyz:masterfrom
fjarri:fix-build

Conversation

@fjarri

@fjarri fjarri commented Sep 18, 2025

Copy link
Copy Markdown
Contributor

Fixes #124

The problem is that various type ID/downcast-related functionality is only used in extend, which is gated behind the dev feature now. Doesn't seem to be possible to cleanly extract all of these methods into the dev module, hence they have to be gated.

I added a cargo hack run to CI to detect future occurrences of this.

@coveralls

Copy link
Copy Markdown

Pull Request Test Coverage Report for Build 17836524665

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.5%) to 68.154%

Files with Coverage Reduction New Missed Lines %
manul/src/session/tokio.rs 6 87.18%
Totals Coverage Status
Change from base Build 17680271010: 0.5%
Covered Lines: 2414
Relevant Lines: 3542

💛 - Coveralls

@fjarri
fjarri merged commit f648237 into entropyxyz:master Sep 19, 2025
10 checks passed
@fjarri
fjarri deleted the fix-build branch September 19, 2025 16:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Warnings about unused code

3 participants