Faster RP commits with multi-exponentiation - #184
Closed
dvdplm wants to merge 31 commits into
Closed
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #184 +/- ##
=======================================
Coverage 89.31% 89.32%
=======================================
Files 40 40
Lines 10999 11016 +17
=======================================
+ Hits 9824 9840 +16
- Misses 1175 1176 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dvdplm
marked this pull request as ready for review
March 10, 2025 14:19
dvdplm
commented
Mar 10, 2025
Comment on lines
+67
to
+71
| [[bench]] | ||
| bench = true | ||
| name = "pow" | ||
| harness = false | ||
| path = "benches/pow.rs" |
Contributor
Author
There was a problem hiding this comment.
@fjarri I left these in, but they are not particularly useful long-term I think. I wrote them to check on progress as I was changing code, but I think we should remove them now.
More logical order
dvdplm
marked this pull request as draft
April 11, 2025 10:13
Contributor
Author
|
Putting this back as draft because:
EIther way it's non-urgent and the gains likely minor. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use the
MultiExponentiationBoundedExptrait to speed up commitment creation, which is common operation in some of our ZK Proofs.This optimization had better results for the proofs in CGGMP'21. In the '24 version the impact is less pronounced and we should seriously consider whether the (small) gains are actually worth it.
Performance is essentially unchanged, except for
EncElgandFac.The price we pay is a "powerset" proliferation of normal/wide and secret/public methods. Worth it?