Skip to content

Workflow: use fork SDK repo and optional LLM base URL - #24

Merged
enyst merged 1 commit into
mainfrom
fix/sdk-repo-and-llm-base
Feb 15, 2026
Merged

enyst merged 1 commit into
mainfrom
fix/sdk-repo-and-llm-base

Conversation

@enyst

@enyst enyst commented Feb 15, 2026

Copy link
Copy Markdown
Owner

Fixes PR review workflow behavior when testing in a fork:

  • Sets composite action input sdk-repo to ${{ github.repository }} so it checks out the current repo (e.g. enyst/agent-sdk) instead of defaulting to upstream.
  • Removes hardcoded LLM proxy base URL by default; llm-model / llm-base-url can be overridden via repo variables LLM_MODEL and LLM_BASE_URL.

This avoids accidentally sending requests to the OpenHands LLM proxy when you intend to use a direct provider API key.

Summary by CodeRabbit

  • Chores
    • Updated PR review automation workflow to use repository variables for LLM configuration, enabling customization of model and base URL settings per repository instead of relying on fixed default values.

Co-authored-by: openhands <openhands@all-hands.dev>
@gemini-code-assist

Copy link
Copy Markdown

Note

Gemini is unable to generate a summary for this pull request due to the file types involved not being currently supported.

@coderabbitai

coderabbitai Bot commented Feb 15, 2026

Copy link
Copy Markdown
📝 Walkthrough

Walkthrough

The GitHub workflow file has been updated to use repository variables for LLM configuration instead of hardcoded values. The llm-model and llm-base-url now accept dynamic values with sensible defaults, and an sdk-repo input was added to target the correct repository.

Changes

Cohort / File(s) Summary
Workflow Configuration Parametrization
.github/workflows/pr-review-by-openhands.yml
Replaced static LLM configuration (llm-model, llm-base-url) with repository variable references, each with default fallback values. Added sdk-repo input parameter to specify the target repository explicitly.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

Poem

🐰 The workflow takes flight with variables so bright,
No more hardcoded chains holding tight,
Defaults in place, flexibility gained,
Configuration flows—beautifully untamed! ✨

🚥 Pre-merge checks | ✅ 3 | ❌ 1
❌ Failed checks (1 warning)
Check name Status Explanation Resolution
Merge Conflict Detection ⚠️ Warning ❌ Merge conflicts detected (2 files):

⚔️ .github/actions/pr-review/action.yml (content)
⚔️ .github/workflows/pr-review-by-openhands.yml (content)

These conflicts must be resolved before merging into main.
Resolve conflicts locally and push changes to this branch.
✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately reflects the main changes: using the fork SDK repo and adding optional LLM base URL support through repository variables.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✏️ Tip: You can configure your own custom pre-merge checks in the settings.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch fix/sdk-repo-and-llm-base
⚔️ Resolve merge conflicts (beta)
  • Auto-commit resolved conflicts to branch fix/sdk-repo-and-llm-base
  • Create stacked PR with resolved conflicts
  • Post resolved changes as copyable diffs in a comment

No actionable comments were generated in the recent review. 🎉

🧹 Recent nitpick comments
.github/workflows/pr-review-by-openhands.yml (1)

44-45: uses still hardcodes enyst/agent-sdk while sdk-repo is dynamic.

When this workflow runs in a fork (e.g., testing a PR within the fork itself), sdk-repo correctly resolves to the fork via github.repository, but uses on line 45 still fetches the composite action from enyst/agent-sdk. Since GitHub Actions requires uses to be a literal (no expressions), this can't be fully fixed, but it's worth a comment so future maintainers aren't surprised that the action code always comes from upstream.

📝 Suggested comment
         steps:
             - name: Run PR Review
+              # Note: `uses` must be a literal; forks will still pull the action from enyst/agent-sdk
               uses: enyst/agent-sdk/.github/actions/pr-review@main

Also applies to: 54-55


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@enyst
enyst merged commit 14823aa into main Feb 15, 2026
15 of 21 checks passed
@enyst
enyst deleted the fix/sdk-repo-and-llm-base branch February 15, 2026 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants