Revert 1bf557ed: fix path to agent_script.py - #25
Conversation
This reverts commit 1bf557e.
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. ✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Summary of ChangesHello @enyst, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request addresses a broken GitHub Actions workflow by reverting a previous change that specified an incorrect file path for a critical script. The composite action now correctly locates and executes Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request reverts a previous commit that introduced an incorrect path to agent_script.py in the pr-review composite action. The change corrects the path from ../agent-sdk/... to ../software-agent-sdk/..., which aligns with the directory name where the SDK is checked out. This is a necessary fix to restore the functionality of the workflow. The change is correct, but I have added a suggestion to improve maintainability by avoiding a hardcoded path.
| run: | | ||
| cd pr-repo | ||
| uv run python ../agent-sdk/examples/03_github_workflows/02_pr_review/agent_script.py | ||
| uv run python ../software-agent-sdk/examples/03_github_workflows/02_pr_review/agent_script.py |
There was a problem hiding this comment.
While this correctly fixes the path, it's still hardcoded. This can be brittle and lead to similar issues in the future if the checkout directory name changes. To improve maintainability, consider using a workflow-level environment variable for the SDK path and referencing it here.
For example, you could define an env variable at the job level and use it like ../${{ env.SDK_PATH }}/....
Reverts commit
1bf557edwhich changed the composite action to runagent_script.pyfrom../agent-sdk/....The composite action checks out the SDK into
software-agent-sdk/, so the correct path is:../software-agent-sdk/examples/03_github_workflows/02_pr_review/agent_script.py