Conversation
Resolve AUTOMATION_MODEL for both scripts and preserve the complete LLM configuration. Fall back only for an absent or missing selection; report the actual default model without assuming the active-profile pointer. Add HTTP regressions, regenerate bundle 1.0.3, and explain selection, credential handling, and the server dependency in .pr/selected-profile.html. Co-authored-by: openhands <openhands@all-hands.dev>
|
Important Draft PR not reviewedDraft PRs are not automatically reviewed by default.
To automatically review draft PRs, update your CodeRabbit configuration: reviews:
auto_review:
drafts: trueThanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I am an AI agent acting on behalf of Engel.
Why
OpenHands#547 currently ignores
AUTOMATION_MODEL: choosinggpt-latest-medcan launch the user's unrelated default LLM. This follow-up targets OpenHands#547's branch at1b6a4a3bbfdfa4103b8bb0c32b8754a3afbd9b56.Summary
1.0.3.Human explanation: Read the rendered .pr document · source.
It explains the original bug, selection/fallback rules, existing credential handling, standalone packaging, evidence, and rollout.
Issue Number
Follow-up to OpenHands#547; related to OpenHands#548 and OpenHands/automation#430.
How to Test
uv sync --group test uv run pytest tests/test_automation_llm_provenance.py tests/test_slack_channel_monitor.py skills/github-pr-reviewer/tests/test_main.py -q uv run pytest tests skills/github-pr-reviewer/tests -q npm run build:automations npm run build:skills uv run python scripts/sync_extensions.py --check git diff --check99 focused tests and 896 full-suite tests pass; 24 skipped.
All four new selected-profile HTTP cases fail on the original PR head and pass here.
They exercise the actual profile GET and conversation POST for both scripts, checking credentials, base URL, reasoning effort, selected model, and provenance.
The local HTTP service uses synthetic credentials and models the linked-profile response; it does not replace #4952's server-side tests or demonstrate production deployment.
Syntax checks, bundle/source equality, repository sync, and HTML structure checks pass.
Notes
GitHub rejected creating this directly against OpenHands/extensions with 403 (resource not accessible by integration). This PR targets an exact mirror of OpenHands#547's current head in the enyst fork, keeping the diff limited to this follow-up. Merging here will not update OpenHands#547; apply commit
7a8b3789b879d717dd893b0840b4c28fb74a01eetoOpenHands/extensions:openhands/show-llm-provenance.Provider-linked profiles require Agent Server #4952 (or equivalent) to be deployed. Inline profiles use the existing server API.
The script uses the existing authenticated plaintext read and sends the configuration back to the same Agent Server; it does not activate profiles globally.
A server-side profile selector remains a separate API improvement, explained in the .pr document.
Default provenance uses
default, since the separate active-profile pointer may not identify the concrete settings actually used.The repository sync check retains the existing non-blocking
issue-duplicate-checkercoverage warning.The generic Codex skill validator rejects the existing OpenHands
triggersextension; that frontmatter is unchanged and supported by the repository's own validator.