Remove dimensionality from GUI - #14239
Draft
eilskra wants to merge 1 commit into
Draft
Conversation
Using existing data_origin to achieve same result
Contributor
There was a problem hiding this comment.
Pull request overview
Replaces GUI plot dimensionality checks with data_origin-based tab selection and removes redundant dimensionality metadata.
Changes:
- Centralizes plot-tab availability by data origin.
- Removes dimensionality fields from plotting and parameter models.
- Updates GUI, API, migration, endpoint, and snapshot tests.
Reviewed changes
Copilot reviewed 46 out of 46 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
tests/ert/unit_tests/storage/test_storage_migration.py |
Verifies migrated parameter types. |
tests/ert/unit_tests/run_models/snapshots/test_experiment_serialization/test_that_dumped_single_test_run_matches_snapshot/snake_oilsnake_oil.ert/snake_oil.json |
Removes serialized dimensionality. |
tests/ert/unit_tests/run_models/snapshots/test_experiment_serialization/test_that_dumped_single_test_run_matches_snapshot/poly_examplepoly.ert/poly.json |
Removes serialized dimensionality. |
tests/ert/unit_tests/run_models/snapshots/test_experiment_serialization/test_that_dumped_single_test_run_matches_snapshot/heat_equationconfig.ert/config.json |
Removes serialized dimensionality. |
tests/ert/unit_tests/run_models/snapshots/test_experiment_serialization/test_that_dumped_esmda_matches_snapshot/snake_oilsnake_oil.ert/snake_oil.json |
Removes serialized dimensionality. |
tests/ert/unit_tests/run_models/snapshots/test_experiment_serialization/test_that_dumped_esmda_matches_snapshot/poly_examplepoly.ert/poly.json |
Removes serialized dimensionality. |
tests/ert/unit_tests/run_models/snapshots/test_experiment_serialization/test_that_dumped_esmda_matches_snapshot/heat_equationconfig.ert/config.json |
Removes serialized dimensionality. |
tests/ert/unit_tests/run_models/snapshots/test_experiment_serialization/test_that_dumped_ensemble_smoother_matches_snapshot/snake_oilsnake_oil.ert/snake_oil.json |
Removes serialized dimensionality. |
tests/ert/unit_tests/run_models/snapshots/test_experiment_serialization/test_that_dumped_ensemble_smoother_matches_snapshot/poly_examplepoly.ert/poly.json |
Removes serialized dimensionality. |
tests/ert/unit_tests/run_models/snapshots/test_experiment_serialization/test_that_dumped_ensemble_smoother_matches_snapshot/heat_equationconfig.ert/config.json |
Removes serialized dimensionality. |
tests/ert/unit_tests/run_models/snapshots/test_experiment_serialization/test_that_dumped_ensemble_experiment_matches_snapshot/snake_oilsnake_oil.ert/snake_oil.json |
Removes serialized dimensionality. |
tests/ert/unit_tests/run_models/snapshots/test_experiment_serialization/test_that_dumped_ensemble_experiment_matches_snapshot/poly_examplepoly.ert/poly.json |
Removes serialized dimensionality. |
tests/ert/unit_tests/run_models/snapshots/test_experiment_serialization/test_that_dumped_ensemble_experiment_matches_snapshot/heat_equationconfig.ert/config.json |
Removes serialized dimensionality. |
tests/ert/unit_tests/run_models/snapshots/test_experiment_serialization/test_that_dumped_enif_matches_snapshot/snake_oilsnake_oil.ert/snake_oil.json |
Removes serialized dimensionality. |
tests/ert/unit_tests/run_models/snapshots/test_experiment_serialization/test_that_dumped_enif_matches_snapshot/poly_examplepoly.ert/poly.json |
Removes serialized dimensionality. |
tests/ert/unit_tests/run_models/snapshots/test_experiment_serialization/test_that_dumped_enif_matches_snapshot/heat_equationconfig.ert/config.json |
Removes serialized dimensionality. |
tests/ert/unit_tests/gui/tools/plot/test_plot_window.py |
Tests data-origin tab routing. |
tests/ert/unit_tests/gui/tools/plot/test_plot_api.py |
Updates key-definition expectations. |
tests/ert/unit_tests/gui/tools/plot/test_data_type_keys_widget.py |
Updates key fixtures. |
tests/ert/unit_tests/gui/tools/plot/conftest.py |
Removes dimensionality from API fixtures. |
tests/ert/unit_tests/gui/plotting/ert_plots/test_misfits_plot.py |
Updates misfit key fixtures. |
tests/ert/unit_tests/dark_storage/test_http_endpoints.py |
Updates endpoint response expectations. |
tests/ert/ui_tests/gui/test_rft_visualizations.py |
Validates RFT tabs by origin. |
tests/ert/ui_tests/gui/test_plotting_of_snake_oil.py |
Validates plotting tabs by origin. |
tests/ert/ui_tests/gui/test_breakthrough_visualization.py |
Validates breakthrough tabs by origin. |
src/ert/gui/plotting/widgets/plot_widget.py |
Removes dimensionality from the plotter protocol. |
src/ert/gui/plotting/utils/plot_maps.py |
Defines origin-to-tab mappings. |
src/ert/gui/plotting/shared_plots/ensemble.py |
Removes plot dimensionality. |
src/ert/gui/plotting/plot_window.py |
Selects and remembers tabs by availability. |
src/ert/gui/plotting/plot_api.py |
Removes dimensionality from plot keys. |
src/ert/gui/plotting/everest_plots/everest_objective_function_plot.py |
Removes plot dimensionality. |
src/ert/gui/plotting/everest_plots/everest_gradients_plot.py |
Removes plot dimensionality. |
src/ert/gui/plotting/everest_plots/everest_controls_plot.py |
Removes plot dimensionality. |
src/ert/gui/plotting/everest_plots/everest_constraints_plot.py |
Removes plot dimensionality. |
src/ert/gui/plotting/everest_plots/everest_batch_objective_function_plot.py |
Removes plot dimensionality. |
src/ert/gui/plotting/ert_plots/std_dev.py |
Removes plot dimensionality. |
src/ert/gui/plotting/ert_plots/statistics.py |
Removes plot dimensionality. |
src/ert/gui/plotting/ert_plots/misfits.py |
Removes plot dimensionality. |
src/ert/gui/plotting/ert_plots/histogram.py |
Removes plot dimensionality. |
src/ert/gui/plotting/ert_plots/gaussian_kde.py |
Removes plot dimensionality. |
src/ert/gui/plotting/ert_plots/distribution.py |
Removes plot dimensionality. |
src/ert/gui/plotting/ert_plots/cesp.py |
Removes plot dimensionality. |
src/ert/config/surface_config.py |
Removes parameter dimensionality. |
src/ert/config/gen_kw_config.py |
Removes parameter dimensionality. |
src/ert/config/field.py |
Removes parameter dimensionality. |
src/ert/config/everest_control.py |
Removes parameter dimensionality. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #14239 +/- ##
==========================================
+ Coverage 91.97% 92.02% +0.05%
==========================================
Files 484 484
Lines 33676 33667 -9
==========================================
+ Hits 30972 30981 +9
+ Misses 2704 2686 -18
Flags with carried forward coverage won't be shown. Click here to find out more.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Using existing data_origin to achieve same result
Issue
Resolves #14234
Approach
Short description of the approach
(Screenshot of new behavior in GUI if applicable)
git rebase -i main --exec 'just rapid-tests')When applicable
merge screenshot-PR in ert-testdata before merging this PR.