Log param update strategies - #14320
Conversation
|
Based on the sorrounding logs it seems like it would be more correct to change to past tense? |
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #14320 +/- ##
==========================================
- Coverage 91.92% 91.10% -0.83%
==========================================
Files 485 498 +13
Lines 33655 36225 +2570
==========================================
+ Hits 30939 33003 +2064
- Misses 2716 3222 +506
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
Proposed format instead:
|
Yes, this is a good proposal :) |
6c51b23 to
6c3b01c
Compare
|
Screenshots differ from baselines. A baseline update PR has been prepared: equinor/ert-testdata#110 |
6c3b01c to
97a7734
Compare
|
Definitely a false negative from ertomatic. @berland why was this triggered this time? |
|
Screenshots differ from baselines. A baseline update PR has been prepared: equinor/ert-testdata#111 |
|
Please see PR description for finalized format |
|
Or maybe it isn't a false negative, because the coordinates are actually changed. However, as I have only done a refactor and added logs this should not have modified that part of the code |
|
False negative from ertomatic. See #13932 (comment) |
There was a problem hiding this comment.
🟡 Changes recommended
The new logging/refactor introduces misleading warning text and unguarded INFO-level formatting work, and the new user-visible log behavior should be covered by an automated test.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR addresses #14260 by ensuring the configured update strategy per parameter group is logged during analysis updates, improving traceability of which localization strategy is applied.
Changes:
- Refactors
build_strategy_map()to centralize strategy construction/selection logic into helper functions. - Adds an INFO log summary that groups parameter names by update strategy.
File summaries
| File | Description |
|---|---|
src/ert/analysis/_es_update.py |
Refactors strategy-map construction and adds grouped INFO logging of update strategies per parameter group. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 3
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Separate different error cases when resolving strategy Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
There was a problem hiding this comment.
🟡 Changes recommended
Exact-type dispatch breaks previously supported parameter-config subclasses, and the new clustering assertion is insufficiently precise.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 2
- Review effort level: Balanced
| if param_cfg.update_strategy is None: | ||
| return None | ||
|
|
||
| handler = strategy_handlers.get(type(param_cfg)) |
f2f2578 to
38fcb46
Compare
|
Got some refactor changes from CoPilot which seemed nice. It seems they were less nice, and that behavioral changes were added... |
Issue
Resolves #14260
Approach
Adds the following logs (triggered when running poly):
git rebase -i main --exec 'just rapid-tests')