Skip to content

Fix rft_qc_tool screenshot tests - #14335

Merged
HakonSohoel merged 1 commit into
equinor:mainfrom
HakonSohoel:fix-rft-qc-tool-screenshot-tests
Sep 3, 2026
Merged

Fix rft_qc_tool screenshot tests#14335
HakonSohoel merged 1 commit into
equinor:mainfrom
HakonSohoel:fix-rft-qc-tool-screenshot-tests

Conversation

@HakonSohoel

@HakonSohoel HakonSohoel commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Make sure all points are visible for the image comparison

  • PR title captures the intent of the changes, and is fitting for release notes.
  • Added appropriate release note label
  • Commit history is consistent and clean, in line with the contribution guidelines.
  • Make sure unit tests pass locally after every commit (git rebase -i main --exec 'just rapid-tests')

When applicable

  • When screenshots are changed: Review screenshot-PR in ert-testdata,
    merge screenshot-PR in ert-testdata before merging this PR.
  • When there are user facing changes: Updated documentation
  • New behavior or changes to existing untested code: Ensured that unit tests are added (See Ground Rules).
  • Large PR: Prepare changes in small commits for more convenient review
  • Bug fix: Add regression test for the bug
  • Bug fix: Add backport label to latest release (format: 'backport release-branch-name')

Make sure all points are visible for the image comparison
@HakonSohoel HakonSohoel added the release-notes:skip If there should be no mention of this in release notes label Sep 1, 2026
@HakonSohoel HakonSohoel added this to SCOUT Sep 1, 2026
@HakonSohoel HakonSohoel moved this to In Progress in SCOUT Sep 1, 2026
@HakonSohoel HakonSohoel self-assigned this Sep 1, 2026
@ertomatic

Copy link
Copy Markdown
Collaborator

Screenshots differ from baselines. A baseline update PR has been prepared: equinor/ert-testdata#114

@codecov-commenter

codecov-commenter commented Sep 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 91.72%. Comparing base (4e36dd4) to head (125b017).

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #14335      +/-   ##
==========================================
- Coverage   91.75%   91.72%   -0.04%     
==========================================
  Files         485      485              
  Lines       34708    34708              
==========================================
- Hits        31848    31835      -13     
- Misses       2860     2873      +13     
Flag Coverage Δ
cli-tests 35.70% <ø> (ø)
fuzz 43.89% <ø> (ø)
gui-tests 58.17% <ø> (-0.01%) ⬇️
performance-and-unit-tests 81.01% <ø> (-0.04%) ⬇️
test 45.28% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.
see 2 files with indirect coverage changes

@codspeed-hq

codspeed-hq Bot commented Sep 1, 2026

Copy link
Copy Markdown

Merging this PR will not alter performance

✅ 36 untouched benchmarks


Comparing HakonSohoel:fix-rft-qc-tool-screenshot-tests (125b017) with main (4e36dd4)

Open in CodSpeed

@HakonSohoel HakonSohoel moved this from In Progress to Ready for Review in SCOUT Sep 2, 2026
@github-project-automation github-project-automation Bot moved this from Ready for Review to Reviewed in SCOUT Sep 2, 2026
HakonSohoel pushed a commit to equinor/ert-testdata that referenced this pull request Sep 3, 2026
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
@HakonSohoel
HakonSohoel merged commit a5f383c into equinor:main Sep 3, 2026
68 of 69 checks passed
@github-project-automation github-project-automation Bot moved this from Reviewed to Done in SCOUT Sep 3, 2026
@HakonSohoel
HakonSohoel deleted the fix-rft-qc-tool-screenshot-tests branch September 3, 2026 07:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

release-notes:skip If there should be no mention of this in release notes

Projects

Status: Done

Development

Successfully merging this pull request may close these issues.

4 participants