Skip to content

Update upload and uninstall messages for clarity #85

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
RKBoss6 wants to merge 8 commits into
base: master
Choose a base branch
from
Draft

Update upload and uninstall messages for clarity #85

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
ba9b816
Update upload and uninstall messages for clarity
RKBoss6 Jan 14, 2026
5467bea
Fix message formatting in upload and uninstall functions
RKBoss6 Jan 14, 2026
16bb997
Update comms.js
RKBoss6 Jan 19, 2026
12dbf3e
Fix promise chain for uninstalling app message so uninstall name works
RKBoss6 Jan 21, 2026
91de1a9
Change upload message from 'Installing' to 'Downloading'
RKBoss6 Jan 21, 2026
4e4f803
Refactor CODE_PROGRESSBAR for improved rendering with round progress bar
RKBoss6 Jan 21, 2026
3ff983d
Fix message formatting for firmware update notification
RKBoss6 Jan 21, 2026
78ee683
Use showAppInfo
RKBoss6 Jun 2, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions js/comms.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,7 +323,8 @@
// Start the upload
function doUpload() {
Progress.show({min:0.05, max:0.10}); // 5-10% for progress writing
Comms.showMessage(`Installing\n${app.id}...`).
var msg = app.id=="fwupdate"?`Updating Firmware...`:`Installing\n${app.name}...`

Check warning on line 326 in js/comms.js

View workflow job for this annotation

GitHub Actions / test 

Unexpected var, use let or const instead
Comment thread
RKBoss6 marked this conversation as resolved.
Outdated
Comms.showMessage(msg).
then(() => Comms.write("\x10"+Comms.getProgressCmd()+"\n", {noWait:true})).
then(() => {
doUploadFiles();
Expand Down Expand Up @@ -507,7 +508,7 @@
/* App Info now doesn't contain .files, so to erase, we need to
read the info file ourselves. */
return (options.noReset ? Promise.resolve() : Comms.reset()).
then(()=>Comms.showMessage(`Erasing\n${app.id}...`)).
then(()=>Comms.showMessage(`Uninstalling\n${app.name}...`)).
then(()=>options.containsFileList ? app : Comms.getAppInfo(app)).
then(app=>{
let cmds = '';
Expand Down
Loading