ops-catalog: materialize stats to Bigtable#2955
Open
williamhbaker wants to merge 4 commits into
Open
Conversation
Move from its previous location in control-plane-api to the ops crate so the upcoming Bigtable read client can share the definition.
williamhbaker
force-pushed
the
wb/stats-next
branch
from
9dd17d1 to
3c7804d
Compare
Read side of the `catalog_stats_<grain>` tables that the new stats-view materialization will write. Wraps the BigTable data API behind name/range/prefix fetchers, each returning a coroutine-backed stream.
The new catalog-stats client and its integration tests need a BigTable endpoint; provide one via the cloud-sdk emulator wrapped in a systemd unit and a mise task. The local control-plane agent depends on the emulator so the dual-read path in `PGControlPlane` has somewhere to go, and platform-test runs `local:bigtable` before nextest so the same integration tests run in CI.
`update_l2_reporting` populates the new derivation in parallel with the old one and stamps each L1 source with `not_before` = today so the shadow doesn't backfill history during rollout.
williamhbaker
force-pushed
the
wb/stats-next
branch
from
3c7804d to
2373c29
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
update_l2_reportingcontrol plane API. This is needed for the local Bigtable stats materialization to work. Once the control plane API is deployed on this new code, it will also cause it to publish the new L2 derivation in production.Per the above, prior to deploying the new control plane API on this code, we should create the new reporting-dedicated data plane. Then just after the control plane API is deployed, call the
update_l2_reportingendpoint with the default data plane parameter set to that reporting data plane so that the new L2 derivation is created there.Workflow steps:
(How does one use this feature, and how has it changed)
Documentation links affected:
(list any documentation links that you created, or existing ones that you've identified as needing updates, along with a brief description)
Notes for reviewers:
(anything that might help someone review this PR)