Conversation
|
|
||
| void BlockHeader::streamRLPFields(RLPStream& _s) const | ||
| { | ||
| bigint nnn = m_number; // Fix rlp stream issue with uint65_t |
There was a problem hiding this comment.
Is it supposed to fix the case when block number doesn't in 64 bit?
But it doesn't fix it, because m_number is still uint64_t
There was a problem hiding this comment.
Also there are some proposals to require the limit for block nuumber and timestamp, so I'm not sure it makes sense to change it now.
https://eips.ethereum.org/EIPS/eip-1985
There was a problem hiding this comment.
It fixes the test. Because RLPStream << was working incorrectly with u64int_t
There was a problem hiding this comment.
What do you mean exactly? Maybe we should fix operator<< for uint64_t or something
(Some tests currently fail anyway)
There was a problem hiding this comment.
Yes. I had blockchain/invalidblocks/bcInvalidHeader/timestamp4 test failing without this change. I assume the issue is in << operation
There was a problem hiding this comment.
I can't find this test, what are header values there?
There was a problem hiding this comment.
sorry I was out of laptop.
it is this test:
BlockchainTests/InvalidBlocks/bcUncleHeaderValidity/incorrectUncleTimestamp4
I set timestamp of the uncleheader to 500000000000 + previous block (~1000)
and the value I get rlp::85746a528800. but testeth gives me RLP encode of this argument rlp::846a528800
unless I explicitly say that it is a bigint in that function. the fix is dirty because I just try to make the tests pass
|
|
||
| //New Tests | ||
| BOOST_AUTO_TEST_CASE(stArgsZeroOneBalance){} | ||
| BOOST_AUTO_TEST_CASE(stEWASMTests){} |
There was a problem hiding this comment.
Does that mean we can't use testeth anymore with https://github.com/ewasm/hera ?
There was a problem hiding this comment.
you can use your fork sure.
The issue is that new forks will not be supported in testeth.
There was a problem hiding this comment.
I mean if you have stEWASMTests somewhere and use testeth to run it.
skip Berlin in bc and gtests
3 participants
No description provided.