tests(amsterdam): add BAL missing withdrawal account tests#2652
Merged
fselmo merged 1 commit intoethereum:forks/amsterdamfrom Apr 10, 2026
Merged
Conversation
edg-l
force-pushed
the
tests/bal-missing-withdrawal-account
branch
from
b169e5c to
ac4722c
Compare
Add tests verifying that clients reject blocks where the BAL omits an account modified by a withdrawal (EIP-4895 x EIP-7928 interaction). The existing test_bal_invalid_missing_account only covers accounts modified by transactions. These new tests cover the withdrawal case: - test_bal_invalid_missing_withdrawal_account: block with tx + withdrawal, BAL missing the withdrawal recipient - test_bal_invalid_missing_withdrawal_account_empty_block: empty block with only a withdrawal, BAL missing the recipient - test_bal_invalid_missing_withdrawal_account_consistent_state_root: same as above but with rlp_modifier overriding state_root to simulate a malicious builder crafting a self-consistent invalid block
edg-l
force-pushed
the
tests/bal-missing-withdrawal-account
branch
from
ac4722c to
96099da
Compare
fselmo
approved these changes
Apr 10, 2026
Contributor
fselmo
left a comment
fselmo
left a comment
There was a problem hiding this comment.
Thanks for this! This is great coverage to have. I will iterate on some more related test cases 👍🏼
5 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add tests verifying that clients reject blocks where the BAL (EIP-7928) omits an account that was modified by a withdrawal (EIP-4895).
The existing
test_bal_invalid_missing_accountonly covers accounts modified by transactions. These new tests cover the withdrawal case: the BAL must include every account whose state changed during the withdrawal/request phase, not just the accounts it claims to cover.New tests:
test_bal_invalid_missing_withdrawal_account- block with 1 tx + 1 withdrawal, BAL missing the withdrawal recipienttest_bal_invalid_missing_withdrawal_account_empty_block- empty block with 1 withdrawal, BAL missing the recipientTest plan
test_block_access_lists_invalid.pypass (no regressions)ruff checkandruff format --checkpass