hive,libhive: add simulatorsVersion to hive and results JSONs#1033
Open
marioevz wants to merge 1 commit intoethereum:masterfrom
Open
hive,libhive: add simulatorsVersion to hive and results JSONs#1033marioevz wants to merge 1 commit intoethereum:masterfrom
simulatorsVersion to hive and results JSONs#1033marioevz wants to merge 1 commit intoethereum:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Use git's command
git rev-parse HEADto obtain the current folder's HEAD commit and put it in:1*.jsonin the logs folder)If the git command fails, then the field will simply not show up in any of the json files.
This differs from the build commit since, even if we don't rebuild the hive binary on any given deployment, the simulator's commit will still be updated to the latest version of the folder.
This will allow to better cross-reference any failing tests to either a newer client commit or a newer simulators commit.