simulators: remove obsolete consensus, graphql, testnet, portal, and clique simulators#1388
Open
spencer-tb wants to merge 2 commits intoethereum:masterfrom
Open
simulators: remove obsolete consensus, graphql, testnet, portal, and clique simulators#1388spencer-tb wants to merge 2 commits intoethereum:masterfrom
spencer-tb wants to merge 2 commits intoethereum:masterfrom
Conversation
danceratopz
reviewed
Mar 11, 2026
Member
danceratopz
left a comment
There was a problem hiding this comment.
Thanks @spencer-tb for pushing and implementing this clean-up!
I would have personally preferred:
- To add new doc content as a separate PR (from this otherwise subtractive PR).
- To remove each simulator as a separate commit (or even separate PRs, as the the merge method seems to be fixed at "Squash and merge" for me), just in case we ever needed to (partially) revert the decision.
But if it's deemed ok to yolo, then it's fine for me. It is in line with what we decided 👍 but as-is, I would prefer if @fjl chimed in to approve and merge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ethereum/consensus, replaced byethereum/eels/*consume-rlpethereum/graphql, not consensus critical, limited cross client valueeth2/testnet, PoW to PoS transition testing, obsolete since the Mergeeth2/enginetransition tests, TTD based scenarios no longer relevantportal/*, Portal Network project abandonedsmoke/clique, Clique PoA deprecateddevp2pportal discv5 entryContext
https://notes.ethereum.org/@spencer/hive-purge/