Skip to content

Update German (de) translation - add 107 missing keys#414

Open
maojianian25-png wants to merge 3 commits into
ethereumfollowprotocol:mainfrom
maojianian25-png:update-de-translation
Open

Update German (de) translation - add 107 missing keys#414
maojianian25-png wants to merge 3 commits into
ethereumfollowprotocol:mainfrom
maojianian25-png:update-de-translation

Conversation

@maojianian25-png

Copy link
Copy Markdown

German Translation Update

This PR adds 107 missing translation keys to the German (de) translation file, bringing it from 169/276 to 276/276 complete.

Changes

  • Added translations for all missing keys including: notifications, swipe UI, keyboard/mouse controls, team page, integrations page, share features, and more
  • All crypto-specific terminology properly translated (onchain, wallet, ENS, POAP, etc.)

Bounty Reference

Per https://docs.efp.app/translationbounty/

Reward Info

@vercel

vercel Bot commented Jun 9, 2026

Copy link
Copy Markdown

@maojianian25-png is attempting to deploy a commit to the EthID Team on Vercel.

A member of the Team first needs to authorize it.

@greptile-apps

greptile-apps Bot commented Jun 9, 2026

Copy link
Copy Markdown

Greptile Summary

This PR completes the German (de) locale by adding 107 previously missing translation keys, bringing coverage from 169/276 to 276/276, and removes several stray blank lines throughout the file.

  • All new crypto and UI-specific keys (notifications, swipe controls, keyboard/mouse hints, team page, integrations, share features) are included and the terminology is generally appropriate.
  • Two linguistic issues were found: followersYouKnow.followThem uses the wrong verb form (\"folge ihnen\" instead of \"folgen ihnen\"), and notifications.follow/notifications.unfollow use simple present tense while every other notification string in the file uses German Perfekt.

Confidence Score: 5/5

Safe to merge — changes are confined to a single locale JSON file with no logic impact; any linguistic corrections can be made in a follow-up.

The change is a pure translation addition to one JSON file. The two linguistic findings are wording/grammar nits that do not break functionality and can be iterated on after merge.

public/locales/de/translations.json — two translation quality issues worth fixing before or shortly after merge.

Important Files Changed

Filename Overview
public/locales/de/translations.json Adds 107 missing translation keys to complete German locale (169→276 keys); also removes scattered blank lines. Two minor linguistic issues: wrong verb form for followersYouKnow.followThem and tense inconsistency in follow/unfollow notifications vs. the rest of the notification strings.

Flowchart

%%{init: {'theme': 'neutral'}}%%
flowchart TD
    A[translations.json EN source\n276 keys] --> B{PR #414}
    B --> C[DE file: 169 keys before]
    B --> D[+107 missing keys added]
    C --> E[DE file: 276/276 complete]
    D --> E
    E --> F[Notifications section\nfollow/unfollow: present tense ⚠️\nothers: Perfekt tense ✓]
    E --> G[followersYouKnow section\nfollowThem: 'folge ihnen' ⚠️\nfollowsThem: 'folgt ihnen' ✓]
    E --> H[Swipe / Keyboard / Mouse\nTeam / Integrations / Share\n✓ correct]
Loading

Fix All in Conductor Fix All in Cursor Fix All in Codex Fix All in Claude Code

Reviews (3): Last reviewed commit: "fix: address German translation review n..." | Re-trigger Greptile

Comment thread public/locales/de/translations.json Outdated
Comment thread public/locales/de/translations.json Outdated
Comment thread public/locales/de/translations.json Outdated
Comment thread public/locales/de/translations.json Outdated
@maojianian25-png

Copy link
Copy Markdown
Author

Thanks for the review. I pushed a follow-up commit addressing the remaining German translation feedback and ensured the locale file ends with a trailing newline.

@maojianian25-png

Copy link
Copy Markdown
Author

Thanks for the follow-up review. I pushed a new commit addressing the remaining German wording suggestions: restored the onchain identity-stack meaning in the team description and kept the swipe-specific wording in the swipe UI strings.

@maojianian25-png

Copy link
Copy Markdown
Author

Hi maintainers 👋

This PR is currently blocked due to a Vercel deployment authorization issue (Authorization required to deploy). This is a Vercel team configuration issue, not a code problem.

Could someone please authorize the Vercel deployment or bypass the check? The translation bounty ($200 USDC) is pending merge.

@ethereumfollowprotocol

@maojianian25-png

Copy link
Copy Markdown
Author

Addressed all Greptile review feedback:

  • notifications.unmute: Changed to "hat deine Stummschaltung aufgehoben" (correct inverse of mute)
  • swipe description second: Changed "für Folgen" to "zum Folgen" (correct dative)
  • summary.txn/txns: Changed to lowercase to match English casing
  • Added trailing newline at end of file

Please re-review!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant