fix(dumbo): preserve original error when transaction rollback fails#183
Open
JonCanning wants to merge 1 commit into
Open
fix(dumbo): preserve original error when transaction rollback fails#183JonCanning wants to merge 1 commit into
JonCanning wants to merge 1 commit into
Conversation
When a withTransaction callback throws, executeInTransaction attempts a rollback. If rollback also fails (e.g. connection closed, SQLITE_MISUSE), the rollback error replaces the original callback error — making debugging impossible. Wrap rollback in its own try/catch so the original error is always preserved and re-thrown to the caller.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a withTransaction callback throws, executeInTransaction attempts a rollback. If rollback also fails (e.g. connection closed, SQLITE_MISUSE), the rollback error replaces the original callback error — making debugging impossible.
Wrap rollback in its own try/catch so the original error is always preserved and re-thrown to the caller.