-
Notifications
You must be signed in to change notification settings - Fork 102
Require auth on LiveKit token endpoint and scope rooms per tenant #4424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
NdekoCode
wants to merge
5
commits into
develop
Choose a base branch
from
fix/livekit-unauthenticated-token
base: develop
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
41e1baf
fix(web): require auth on LiveKit token endpoint and scope rooms per …
NdekoCode 882427c
fix: add /graphify-out to .gitignore
NdekoCode ac329ee
fix(web): encode and normalize the LiveKit room name
NdekoCode 48cb029
fix(web): bind the LiveKit token to its room and drop canUpdateOwnMet…
NdekoCode c5dd242
docs(web): note why the LiveKit route uses the session tenant
NdekoCode File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,59 +1,45 @@ | ||
| import { AccessToken } from "livekit-server-sdk"; | ||
| import { NextRequest, NextResponse } from "next/server"; | ||
| import { authenticatedGuard } from '@/core/services/server/guards/authenticated-guard-app'; | ||
| import { AccessToken } from 'livekit-server-sdk'; | ||
| import { NextRequest, NextResponse } from 'next/server'; | ||
|
|
||
| export async function GET(req: NextRequest) { | ||
| const room = req.nextUrl.searchParams.get("roomName"); | ||
| const username = req.nextUrl.searchParams.get("username"); | ||
| const res = new NextResponse(); | ||
| const { user } = await authenticatedGuard(req, res); | ||
|
|
||
| if (!room || typeof room !== 'string' || room.trim() === '') { | ||
| return NextResponse.json( | ||
| { error: 'Missing or invalid "roomName" query parameter' }, | ||
| { status: 400 } | ||
| ); | ||
| } | ||
| // Session tenant, not the guard's auth-tenant-id cookie: that one is client-writable | ||
| if (!user || !user.tenantId) { | ||
|
Check warning on line 10 in apps/web/app/api/livekit/route.ts
|
||
| return NextResponse.json({ error: 'Unauthorized' }, { status: 401 }); | ||
|
coderabbitai[bot] marked this conversation as resolved.
NdekoCode marked this conversation as resolved.
|
||
| } | ||
|
|
||
| if (!username || typeof username !== 'string' || username.trim() === '') { | ||
| return NextResponse.json( | ||
| { error: 'Missing or invalid "username" query parameter' }, | ||
| { status: 400 } | ||
| ); | ||
| } | ||
| const room = req.nextUrl.searchParams.get('roomName')?.trim(); | ||
|
|
||
| const apiKey = process.env.LIVEKIT_API_KEY; | ||
| const apiSecret = process.env.LIVEKIT_API_SECRET; | ||
| const wsUrl = process.env.NEXT_PUBLIC_LIVEKIT_URL; | ||
| if (!room) { | ||
| return NextResponse.json({ error: 'Missing or invalid "roomName" query parameter' }, { status: 400 }); | ||
| } | ||
|
|
||
| if (!apiKey || !apiSecret || !wsUrl) { | ||
| console.error("Server misconfigured: missing environment variables."); | ||
| return NextResponse.json( | ||
| { error: "Server misconfigured" }, | ||
| { status: 500 } | ||
| ); | ||
| } | ||
| const apiKey = process.env.LIVEKIT_API_KEY; | ||
| const apiSecret = process.env.LIVEKIT_API_SECRET; | ||
| const wsUrl = process.env.NEXT_PUBLIC_LIVEKIT_URL; | ||
|
|
||
| try { | ||
| const at = new AccessToken(apiKey, apiSecret, { identity: username, ttl: '1h' }); | ||
| at.addGrant({ | ||
| room, | ||
| roomJoin: true, | ||
| canPublish: true, | ||
| canSubscribe: true, | ||
| roomRecord: true, | ||
| roomCreate: true, | ||
| roomAdmin: true, | ||
| recorder: true, | ||
| roomList: true, | ||
| canUpdateOwnMetadata: true, | ||
| agent: true, | ||
| canPublishData: true, | ||
| }); | ||
| const token = await at.toJwt(); | ||
| return NextResponse.json({ token: token }); | ||
| } catch (error) { | ||
| console.error("Failed to generate token:", error); | ||
| return NextResponse.json( | ||
| { error: "Failed to generate token" }, | ||
| { status: 500 } | ||
| ); | ||
| } | ||
| if (!apiKey || !apiSecret || !wsUrl) { | ||
| console.error('Server misconfigured: missing environment variables.'); | ||
| return NextResponse.json({ error: 'Server misconfigured' }, { status: 500 }); | ||
| } | ||
|
|
||
| try { | ||
| const at = new AccessToken(apiKey, apiSecret, { identity: user.email || user.id, ttl: '1h' }); | ||
|
NdekoCode marked this conversation as resolved.
|
||
| at.addGrant({ | ||
| // Rooms are shared by link, so scoping per tenant keeps a leaked link within its tenant | ||
| room: `${user.tenantId}:${room}`, | ||
|
NdekoCode marked this conversation as resolved.
|
||
| roomJoin: true, | ||
| canPublish: true, | ||
| canSubscribe: true, | ||
| canPublishData: true | ||
| }); | ||
| const token = await at.toJwt(); | ||
| return NextResponse.json({ token: token }); | ||
|
NdekoCode marked this conversation as resolved.
NdekoCode marked this conversation as resolved.
|
||
| } catch (error) { | ||
| console.error('Failed to generate token:', error); | ||
| return NextResponse.json({ error: 'Failed to generate token' }, { status: 500 }); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.