Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
bashkit | 89e35b6 | Commit Preview URL | May 08 2026, 09:15 AM |
0ce260b to
1a22560
Compare
1a22560 to
89e35b6
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
credential_placeholder(...), causing script-visible placeholders to be stale or absent while HTTP hooks expected newly generated tokens.from_snapshot()/restore_snapshot()flows without exposing the real credential, so restored instances could silently fail network auth.Description
restore_live_bash_with_env_overridesandplaceholder_env_overrideshelper functions incrates/bashkit-python/src/lib.rs.PyBash::restore_snapshotandBashTool::restore_snapshotto collect placeholder env overrides and call the new restore helper so placeholders remain aligned with active HTTP credential hooks.test_bashtool_from_snapshot_reapplies_placeholder_env_after_restoreincrates/bashkit-python/tests/test_network_credentials.pyto assert that a placeholder env is present afterBashTool.from_snapshot()when the source snapshot lacks placeholder env state.Testing
cargo fmt --all, which completed successfully.python -m pytest crates/bashkit-python/tests/test_network_credentials.py -k from_snapshotwhich failed in this environment withModuleNotFoundError: No module named 'bashkit'during test collection so the Python-level test could not be executed here.cargo test -p bashkit-python --no-runwhich began dependency resolution and compilation but could not complete within the validation window (network/dependency fetch in progress), so no final pass/fail was recorded.Codex Task