Warn when passing unknown driver creation options#167
Open
hawahee wants to merge 2 commits into
Open
Conversation
Owner
|
Thanks for the PR! Mind if I make a few changes in your branch? The stringlist method should be generic (as it's used for non geotiff stuff as well), but the check for supported keywords is very helpful though. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
writefunction docstring was incorrectly suggestingcompressionas a driver creation options keyword, but that does not work and has been corrected tocompress.The
stringlistutil function has also been updated to check the provided dict keywords against a list of supported driver creation options keywords, and warn when the provided keyword is unrecognized. No checking or warning is performed on the values passed together with the keywords. I could not find a list of supported driver creation options in GDAL.jl or ArchGDAL.jl, so I hardcoded a list based on the Creation Options in the GDAL GTiff documentation.I see that the
warpstringlistfunction callsstringlist. Does it support the same keywords, or is it for a different purpose?Also, should the
stringlistandwarpstringlistinput argumentdict::Dict{String}be changed todict::Dict{String,String}?Supersedes #166