This repository was archived by the owner on May 2, 2026. It is now read-only.
Request mic permission when user makes or accepts a call - #1326
Closed
TrueWatcher wants to merge 4 commits into
Closed
Request mic permission when user makes or accepts a call#1326TrueWatcher wants to merge 4 commits into
TrueWatcher wants to merge 4 commits into
Conversation
TrueWatcher
changed the title
TrueWatcher
marked this pull request as ready for review
November 18, 2025 15:54
robinlinden
reviewed
Nov 18, 2025
robinlinden
left a comment
robinlinden
left a comment
Collaborator
There was a problem hiding this comment.
How about instead of rejecting the call and opening the settings when the user accepts a call via the notification, we open the call screen where we can request the permission? I think opening the call screen when you accept a call was a todo-item anyway as someone said other messengers did it that way and it might confuse users not to.
I don't want to make mic permission a hard requirement for calls as you can still listen to incoming ones, but I'm fine with adding more reminders about the mic permission in case the user doesn't realize they have to unmute themselves the first call they make.
TrueWatcher
referenced
this pull request
Dec 4, 2025
Contributor
Author
|
replaced with #1331 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On freshly installed app:
When user presses CALL in chat screen, he/she is immediately asked for the mic permission.
If user accepts an incoming call, it is aborted and the user is taken to App Settings (as one cannot use registerForResultActivity from a BroadcastReceiver)
If users denies the mic permission, these reactions are repeated on next occasion.
Closes issue #1315