fix(blog): resolve Leaflet image blobs from the owning PDS - #18
Merged
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix broken Leaflet/blog images by resolving the document author's current PDS before constructing
com.atproto.sync.getBlobURLs.The serializer currently points image blob requests at Slingshot itself. Slingshot is used for identity/record resolution, but the original blob needs to be fetched from the repo owner's PDS.
@ewanc26/atprotoalready exposesresolveIdentityandbuildPdsBlobUrl, so this uses those rather than hard-coding a host.Validation
pnpm check, the focused tests, andpnpm buildon this PR.