Skip to content

fix: prefer reserved capacity during consolidation - #5

Open
capy-ai[bot] wants to merge 2 commits into
mainfrom
capy/reserved-multi-replacement
Open

fix: prefer reserved capacity during consolidation#5
capy-ai[bot] wants to merge 2 commits into
mainfrom
capy/reserved-multi-replacement

Conversation

@capy-ai

@capy-ai capy-ai Bot commented Jun 21, 2026

Copy link
Copy Markdown

Summary

  • prefer reserved offerings when consolidating mixed reserved/on-demand node pools
  • allow reserved consolidation to split existing on-demand nodes into multiple reserved replacement NodeClaims when that lowers effective cost
  • keep reserved nodes from being deleted into on-demand capacity while paid ODCR inventory is available
  • update Go/x dependencies so make vulncheck passes on current advisories

Tests

  • go test ./pkg/controllers/disruption -run '^$'
  • go test ./pkg/controllers/disruption -run TestAPIs -ginkgo.focus='Reserved Capacity' -count=1
  • make vulncheck

Full disruption suite was attempted after installing envtest binaries, but fake-clock TTL specs hung until the Go test timeout; the reserved-capacity-focused specs above pass.

@capy-ai
capy-ai Bot force-pushed the capy/reserved-multi-replacement branch from bfeda72 to c26a945 Compare June 21, 2026 20:55
@capy-ai capy-ai Bot changed the title Prefer reserved capacity during consolidation fix: prefer reserved capacity during consolidation Jun 21, 2026
@capy-ai
capy-ai Bot force-pushed the capy/reserved-multi-replacement branch 3 times, most recently from 12156e0 to d49ec5a Compare June 21, 2026 21:29
Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@capy-ai
capy-ai Bot force-pushed the capy/reserved-multi-replacement branch from d49ec5a to 9d688ac Compare June 21, 2026 21:35
@coveralls

coveralls commented Jun 21, 2026

Copy link
Copy Markdown

Coverage Report for CI Build 27920133191

Coverage decreased (-0.02%) to 80.467%

Details

  • Coverage decreased (-0.02%) from the base build.
  • Patch coverage: 32 uncovered changes across 1 file (85 of 117 lines covered, 72.65%).
  • 1 coverage regression across 1 file.

Uncovered Changes

File Changed Covered %
pkg/controllers/disruption/consolidation.go 75 43 57.33%
Total (3 files) 117 85 72.65%

Coverage Regressions

1 previously-covered line in 1 file lost coverage.

File Lines Losing Coverage Coverage
pkg/controllers/disruption/validation.go 1 87.35%

Coverage Stats

Coverage Status
Relevant Lines: 14847
Covered Lines: 11947
Line Coverage: 80.47%
Coverage Strength: 121402.04 hits per line

💛 - Coveralls

Co-authored-by: capy-ai[bot] <230910855+capy-ai[bot]@users.noreply.github.com>
@capy-ai
capy-ai Bot force-pushed the capy/reserved-multi-replacement branch from f62716a to b01b405 Compare June 21, 2026 22:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants