Skip to content

fix(python): preserve real tracing target in pylance log passthrough #8

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpruijt merged 1 commit into from
Jun 1, 2026
Merged

fix(python): preserve real tracing target in pylance log passthrough #8

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion python/src/tracing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,13 @@ impl tracing_subscriber::Layer<Registry> for LoggingPassthroughRef {

let mut fields = EventToStr::default();
event.record(&mut fields);
log::log!(target: "lance::events", state.level, "target=\"{}\" {}", event.metadata().target(), fields.str);
// Forward the event under its real tracing target (e.g. `lance::file_audit`,
// `lance::dataset::cleanup`) rather than a single fixed `lance::events` target.
// env_logger only filters by the log record's target, so preserving it lets
// `LANCE_LOG` directives target specific event families (e.g. silencing the
// high-volume per-file `lance::file_audit` events while keeping other INFO logs).
let event_target = event.metadata().target();
log::log!(target: event_target, state.level, "target=\"{}\" {}", event_target, fields.str);

if let Some(callback_sender) = state.callback_sender.as_ref() {
let mut args = EventToMap::default();
Expand Down
Loading