✨ server: add card provisioning webhook fields - #1270
Conversation
🦋 Changeset detectedLatest commit: 8646c54 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
WalkthroughCard-updated webhook schemas now accept an optional ChangesCard webhook status reason
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: 🟡 Moderate · up to The webhook contract currently exposes statusChangeReason instead of the required pushProvisioningToken, so consumers will not receive the provisioning token promised by this PR. The PR should not merge until the field name and related schemas, worker handling, tests, and documentation are corrected. Suggested reviewers: 🚥 Pre-merge checks | ✅ 3 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (3 passed)
Full details: Linked Issues checkExplanation The PR adds and documents a
✨ Finishing Touches🧪 Generate unit tests (beta)
✨ Simplify code
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: dcfbbb4a-06f9-44c7-a100-7f42691dd5d7
📒 Files selected for processing (5)
.changeset/slimy-webs-rule.mdserver/test/hooks/panda.test.tsserver/test/workers/hook.test.tsserver/utils/panda.tsserver/workers/hook/worker.ts
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
2152433 to
9997244
Compare
9997244 to
248e047
Compare
There was a problem hiding this comment.
Actionable comments posted: 1
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Pro Plus
Run ID: 3350f202-dd64-401e-b279-e65ae83da3ca
📒 Files selected for processing (5)
.changeset/nine-hands-shave.mdserver/test/hooks/panda.test.tsserver/test/workers/hook.test.tsserver/utils/panda.tsserver/workers/hook/worker.ts
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 248e04784e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
248e047 to
1413517
Compare
1413517 to
24deeb0
Compare
24deeb0 to
d935d75
Compare
There was a problem hiding this comment.
Actionable comments posted: 2
ℹ️ Review info
⚙️ Run configuration
Configuration used: Organization UI
Review profile: ASSERTIVE
Plan: Team
Run ID: 871b4fa7-e329-4087-aa77-c30e087fae1c
📒 Files selected for processing (2)
.changeset/nine-hands-shave.mddocs/src/content/docs/webhooks.md
Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.
d935d75 to
dabc396
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: dabc3963a8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
dabc396 to
8646c54
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1270 +/- ##
==========================================
+ Coverage 72.51% 73.05% +0.53%
==========================================
Files 275 276 +1
Lines 13254 13259 +5
Branches 4610 4610
==========================================
+ Hits 9611 9686 +75
+ Misses 3306 3236 -70
Partials 337 337
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Summary by CodeRabbit
New Features
card_replacedandwallet_provisioned.Bug Fixes
Documentation