Skip to content

coverage on only in CI - #1279

Open
aguxez wants to merge 1 commit into
mainfrom
test-perf
Open

coverage on only in CI#1279
aguxez wants to merge 1 commit into
mainfrom
test-perf

Conversation

@aguxez

@aguxez aguxez commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

what

one-line change in server/vitest.config.mts: vitest coverage runs only when CI is set. CI behavior is unchanged — github actions sets CI=true, so codecov unit reports, the e2e lcov upload, and junit test results all stay exactly as they are.

-    coverage: { enabled: true, reporter: ["lcov"] },
+    coverage: { enabled: !!env.CI, reporter: ["lcov"] },

why

coverage instrumentation was always on, including local runs, where nobody reads the report. measured on a 2-core vps (same worktree, same node_modules, only the flag differs):

scenario coverage on (main) coverage off delta
harness-free set (18 files, 256 tests) 3:03 1:24 −54%
auth api file w/ harness (40 tests) 1:28 1:01 −30%
single light file (statement, 7 tests) 1:02 0:38 −38%

@changeset-bot

changeset-bot Bot commented Sep 1, 2026

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 98e832c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@aguxez
aguxez marked this pull request as ready for review September 1, 2026 17:04
@aguxez
aguxez requested a review from nfmelendez as a code owner September 1, 2026 17:04

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 98e832cf76

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread server/vitest.config.mts
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant