Skip to content

feat: Allow custom image resource path#24

Open
JumpLink wants to merge 2 commits into
excaliburjs:mainfrom
PixelRPG:feature/image-path
Open

feat: Allow custom image resource path#24
JumpLink wants to merge 2 commits into
excaliburjs:mainfrom
PixelRPG:feature/image-path

Conversation

@JumpLink
Copy link
Copy Markdown

@JumpLink JumpLink commented Nov 1, 2021

===:clipboard: PR Checklist :clipboard:===

  • 📌 issue exists in github for these changes
  • 🔬 existing tests still pass
  • 🙈 code conforms to the style guide
  • 📐 new tests written and passing / old tests updated with new scenario(s)
  • 📄 changelog entry added (or not needed)

==================

Closes #23

Changes:

  • Added optional parameter to the constructor of AsepriteResource to allow to overwrite the image path. E.g. to resolve the image path by the build tool.
  • Split frame type in AsepriteRaw to AsepriteRawFrame
  • Do not throw an error if frameTags is not defined

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add option to use a custom image path

1 participant