Skip to content

Fmri utils - #66

Open
IanEisenberg wants to merge 8 commits into
expfactory:masterfrom
IanEisenberg:fmri_utils
Open

Fmri utils#66
IanEisenberg wants to merge 8 commits into
expfactory:masterfrom
IanEisenberg:fmri_utils

Conversation

@IanEisenberg

Copy link
Copy Markdown
Member

No description provided.

@vsoch

vsoch commented Jan 3, 2017

Copy link
Copy Markdown
Member

Do you have a good way to test this against current experiments that require it (to make sure nothing breaks?)

@IanEisenberg

Copy link
Copy Markdown
Member Author

No experiment in expfactory-experiments uses this. I've tested it on the experiments I'm modifying to use it, but those are located in a separate repo. The reason I am adding this as a module to expfactory (rather than keep it in that separate repo) is it adds a simple function for converting javascript experiments into fmri-ready experiments. The function is defined with our scanner in mind however, so let me know if you think it doesn't belong as part of expfactory.

@vsoch

vsoch commented Jan 3, 2017

Copy link
Copy Markdown
Member

I leave it up to your judgment, the eventual plan with expfactory is to have all experiments (and dependencies) in containers, so tweaks to the current version (as long as they don't break anything) are ok with me.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants