Skip to content

test: Make browser e2e tests deterministic and leak-free #1952

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
jeswr wants to merge 2 commits into
base: main
Choose a base branch
from
Open

test: Make browser e2e tests deterministic and leak-free #1952

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b245a74
test: make browser e2e tests deterministic and leak-free
Jul 4, 2026
e856840
Merge branch 'main' into test/e2e-deterministic-waits
jeswr Jul 4, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
49 changes: 33 additions & 16 deletions __tests__/e2e-test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,10 @@ import { firefox, chromium, type BrowserType } from 'playwright';
import { createTestApp } from '../__test_utils__/serve';
import { data } from '../data/socrates';

// Generous timeout for the reasoner to produce a result on slow CI runners,
// kept within the overall 120s jest timeout of each test below
const RESULT_TIMEOUT = 90_000;

describe('Testing browsers', () => {
let server: Server;

Expand All @@ -24,28 +28,41 @@ describe('Testing browsers', () => {
([browserType, browserName]) => {
it(`should be able to call the execute function in ${browserName}`, async () => {
const browser = await browserType.launch();
const page = await browser.newPage();

await page.goto('http://localhost:3001/');
await expect(page.textContent('textarea[id=data]').then((r) => r?.trim())).resolves.toEqual(data.trim());
await expect(page.textContent('div[id=result]').then((r) => r?.trim())).resolves.toEqual('');
// Ensure the browser is always closed, even when an expectation fails;
// a leaked browser stops the jest worker from exiting and hangs CI
try {
const page = await browser.newPage();

await page.click('button[id=execute]');
// Time for new result to be inserted in the DOM
await new Promise((res) => { setTimeout(res, 1000); });
await page.goto('http://localhost:3001/');
await expect(page.textContent('textarea[id=data]').then((r) => r?.trim())).resolves.toEqual(data.trim());
await expect(page.textContent('div[id=result]').then((r) => r?.trim())).resolves.toEqual('');

await expect(page.textContent('textarea[id=data]').then((r) => r?.trim())).resolves.toEqual(data.trim());
await expect(page.textContent('div[id=result]').then((r) => r?.trim())).resolves.toEqual('@prefix : .:Socrates a :Mortal.');
await page.click('button[id=execute]');
// Wait for the reasoner to insert the result into the DOM rather
// than sleeping for a fixed amount of time
await page.waitForFunction(
() => (document.querySelector('div[id=result]')?.textContent ?? '').trim() !== '',
undefined,
{ timeout: RESULT_TIMEOUT },
);

await page.click('button[id=clear]');
// Time for new result to be inserted in the DOM
await new Promise((res) => { setTimeout(res, 1000); });
await expect(page.textContent('textarea[id=data]').then((r) => r?.trim())).resolves.toEqual(data.trim());
await expect(page.textContent('div[id=result]').then((r) => r?.trim())).resolves.toEqual('@prefix : .:Socrates a :Mortal.');

await expect(page.textContent('textarea[id=data]').then((r) => r?.trim())).resolves.toEqual(data.trim());
await expect(page.textContent('div[id=result]').then((r) => r?.trim())).resolves.toEqual('');
await page.click('button[id=clear]');
// Wait for the result to be removed from the DOM
await page.waitForFunction(
() => (document.querySelector('div[id=result]')?.textContent ?? '').trim() === '',
undefined,
{ timeout: RESULT_TIMEOUT },
);

await page.close();
await browser.close();
await expect(page.textContent('textarea[id=data]').then((r) => r?.trim())).resolves.toEqual(data.trim());
await expect(page.textContent('div[id=result]').then((r) => r?.trim())).resolves.toEqual('');
} finally {
await browser.close();
}
}, 120_000);
},
);
Expand Down
Loading