fix: prepend the dependabot breaking-change note so majors trigger a major release - #1963
Draft
jeswr wants to merge 1 commit into
Draft
fix: prepend the dependabot breaking-change note so majors trigger a major release#1963jeswr wants to merge 1 commit into
jeswr wants to merge 1 commit into
Conversation
…major release The BREAKING CHANGE note added for major production dependency bumps was appended to the end of the PR body. Dependabot bodies always contain a Markdown thematic break (---), and the conventional-commits parser stops recognising a BREAKING CHANGE footer note once a --- separates it from the header, so the note was silently ignored and the squashed commit resolved to a patch instead of a major (verified against @semantic-release/commit-analyzer 13.0.1). Prepending the note into the first paragraph makes it resolve to a major release. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
jeswr
enabled auto-merge
July 4, 2026 23:25
jeswr
marked this pull request as draft
July 4, 2026 23:31
auto-merge was automatically disabled
July 4, 2026 23:31
Pull request was converted to draft
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'EYE JS Benchmark'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.25.
| Benchmark suite | Current: 3efa395 | Previous: d129aee | Ratio |
|---|---|---|---|
Run socrates query |
16.82 ops/sec (±1.22%) |
22.2 ops/sec (±2.39%) |
1.32 |
Executing the socrates query |
116 ops/sec (±20.83%) |
3890 ops/sec (±1.67%) |
33.53 |
Run deep taxonomy benchmark [10] |
6.5 ops/sec (±4.72%) |
18.83 ops/sec (±6.56%) |
2.90 |
Run deep taxonomy benchmark [50] |
0.24 ops/sec (±1.01%) |
19.63 ops/sec (±7.26%) |
81.79 |
Run deep taxonomy benchmark [100] |
0.04 ops/sec (±0.95%) |
18.67 ops/sec (±6.95%) |
466.75 |
Run deep taxonomy benchmark [10] [reasoning only] |
7.42 ops/sec (±16.91%) |
4107 ops/sec (±1.65%) |
553.50 |
Run deep taxonomy benchmark [50] [reasoning only] |
0.6 ops/sec (±22.43%) |
4147 ops/sec (±1.85%) |
6911.67 |
Run deep taxonomy benchmark [100] [reasoning only] |
0.16 ops/sec (±24.65%) |
4136 ops/sec (±1.60%) |
25850 |
Run timbl + foaf + rdfs rules |
1.96 ops/sec (±2.70%) |
17.23 ops/sec (±6.18%) |
8.79 |
Run timbl + foaf + owl2rl rules |
1.12 ops/sec (±1.59%) |
17.03 ops/sec (±3.91%) |
15.21 |
Run timbl + rdfs rules |
4.42 ops/sec (±2.74%) |
18.28 ops/sec (±6.60%) |
4.14 |
Run timbl + owl2rl rules |
5.6 ops/sec (±0.52%) |
17.1 ops/sec (±6.85%) |
3.05 |
Run timbl + foaf + rdfs rules [string] |
2.01 ops/sec (±0.48%) |
18.45 ops/sec (±7.08%) |
9.18 |
Run timbl + foaf + owl2rl rules [string] |
1.15 ops/sec (±0.49%) |
18.54 ops/sec (±6.64%) |
16.12 |
Run timbl + rdfs rules [string] |
4.5 ops/sec (±0.41%) |
18.77 ops/sec (±6.77%) |
4.17 |
Run timbl + owl2rl rules [string] |
5.71 ops/sec (±0.35%) |
18.98 ops/sec (±6.47%) |
3.32 |
This comment was automatically generated by workflow using github-action-benchmark.
CC: @jeswr
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #1958.
Bug
#1958 added a step that appends a
BREAKING CHANGE:footer to the body of major production-dependency dependabot PRs, so the squash commit resolves to a semantic-release major. In practice it did not work: dependabot PR bodies always contain a Markdown thematic break (---, before the "Dependabot commands and options" section), andconventional-commits-parser(viaconventional-changelog-angular, as used by@semantic-release/commit-analyzer@13.0.1) stops treating aBREAKING CHANGE:line as a footer note once a---sits between it and the header. The appended note was therefore silently ignored and the release stayed a patch.Verified empirically against the pinned analyzer:
fix: <title>+ raw dependabot body +BREAKING CHANGE:note appended ->patchfix: <title>+BREAKING CHANGE:note prepended + raw dependabot body ->majorFix
Prepend the note into the first paragraph of the body instead of appending it, so it is recognised regardless of the
---blocks lower down. The dedup guard (grep -q '^BREAKING CHANGE:') is unchanged, so re-runs onsynchronizestay idempotent. Minor/patch/dev/actions bumps are unaffected.🤖 Generated with Claude Code