fix: solved argument error for Purpur - #140
Merged
Merged
Conversation
|
Codecov Report❌ Patch coverage is 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed
/rtpintermittently failing (observed on Purpur) withCompletionException - java.lang.IllegalArgumentException: argument type mismatchduring async location search. The Folia region/global-scheduler reflection bridges inPaperPlatformSchedulerandBukkitPlatformScheduleronly caughtReflectiveOperationExceptionaroundMethod.invoke()calls; they now also catchRuntimeExceptionand fall back to the standard Bukkit scheduler instead of letting the exception propagate. This can occur even on non-Folia servers whose classpath carries the Folia regionized-runtime marker class.BukkitPlatformScheduler#executeRegion/executeGlobal/executeGlobalDelayed/executeRegionDelayednow consistently fall back to the standard Bukkit scheduler when the reflective Folia scheduler call fails, instead of silently dropping the task (matching existingPaperPlatformSchedulerbehavior).Added
PaperPlatformSchedulerReflectionFallbackTestandBukkitPlatformSchedulerReflectionFallbackTestsimulate a broken region/global-scheduler reflection call and verify the submitted task still runs via the standard scheduler fallback.PlatformRuntimeCapabilities.PURPUR_REGIONIZEDconstant documenting the exact capability combination that triggered the bug.