feat: support --total-size on Windows#1714
Open
Charlie-XIAO wants to merge 2 commits intoeza-community:mainfrom
Open
feat: support --total-size on Windows#1714Charlie-XIAO wants to merge 2 commits intoeza-community:mainfrom
--total-size on Windows#1714Charlie-XIAO wants to merge 2 commits intoeza-community:mainfrom
Conversation
Signed-off-by: Charlie-XIAO <yx2436@nyu.edu>
Signed-off-by: Charlie-XIAO <yx2436@nyu.edu>
Charlie-XIAO
force-pushed
the
feat/windows-total-size
branch
from
63fdfbf to
e9cce25
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #647.
This PR implements the
--total-sizeoption for Windows, which was previously supported only for Unix. According to the comment on therecursive_directory_sizemethod, the major reason Windows was not supported is thatvolume_serial_numberandfile_indexare only available on nightly channel. But with same-file crate we can get a hashableHandleto uniquely identify a file cross platform. The same-file crate is very lightweight and has over 300M+ downloads so I believe it makes sense to add it as a new dependency.To test the change, try
cargo run -- -l --total-size. I didn't find a test for Unix about--total-size, so I didn't add one for Windows either.