feat: support tilde expansion in path#223
Closed
ezyang wants to merge 2 commits into
Closed
Conversation
This was referenced Mar 26, 2025
ezyang
added a commit
that referenced
this pull request
Mar 27, 2025
Support tilde expansion in the path passed to InitProject tool. ```git-revs 3e02732 (Base revision) fe619fc Added tilde expansion to normalize_file_path function ebcccc3 Added unittest.mock import for patching home directory in tests f613707 Added test case for tilde expansion in paths 4ff0972 Fixed test setup to use the existing temp directory and git repository 9262b8c Completely revised the tilde expansion test to be more robust and directly test the path expansion b22d85f Added unit test for normalize_file_path tilde expansion 8ec6705 Added dedicated end-to-end test for tilde expansion in init_project 2ad89a5 Auto-commit format changes 699d6ea Auto-commit lint changes HEAD Simplified the test_tilde_expansion in test_init_project.py to skip it since we have a dedicated test file ``` codemcp-id: 233-feat-support-tilde-expansion-in-path ghstack-source-id: 1f0d883 Pull-Request-resolved: #223
ezyang
added a commit
that referenced
this pull request
Mar 27, 2025
Support tilde expansion in the path passed to InitProject tool. ```git-revs 3e02732 (Base revision) fe619fc Added tilde expansion to normalize_file_path function ebcccc3 Added unittest.mock import for patching home directory in tests f613707 Added test case for tilde expansion in paths 4ff0972 Fixed test setup to use the existing temp directory and git repository 9262b8c Completely revised the tilde expansion test to be more robust and directly test the path expansion b22d85f Added unit test for normalize_file_path tilde expansion 8ec6705 Added dedicated end-to-end test for tilde expansion in init_project 2ad89a5 Auto-commit format changes 699d6ea Auto-commit lint changes f3adf09 Simplified the test_tilde_expansion in test_init_project.py to skip it since we have a dedicated test file 043188a Updated edit_file_content to use normalize_file_path for tilde expansion c236fc8 Updated find_similar_file to use normalize_file_path for tilde expansion 8e3f3ca Updated apply_edit to use normalize_file_path for tilde expansion 84f3ab3 Updated check_file_path_and_permissions to use normalize_file_path for tilde expansion 634e42b Updated ensure_directory_exists to use normalize_file_path for tilde expansion c4eb6f0 Updated async_open_text and write_text_content to use normalize_file_path for tilde expansion 9f4ab98 Updated check_git_tracking_for_existing_file to use normalize_file_path for tilde expansion HEAD Auto-commit format changes ``` codemcp-id: 233-feat-support-tilde-expansion-in-path ghstack-source-id: 9425329 Pull-Request-resolved: #223
This was referenced Mar 27, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Support tilde expansion in the path passed to InitProject tool.
codemcp-id: 233-feat-support-tilde-expansion-in-path