fix memory_mallctl_helper_test when jemalloc is installed#2555
Open
ahornby wants to merge 2 commits intofacebook:mainfrom
Open
fix memory_mallctl_helper_test when jemalloc is installed#2555ahornby wants to merge 2 commits intofacebook:mainfrom
ahornby wants to merge 2 commits intofacebook:mainfrom
Conversation
) Summary: Fix intermittent failure in HeapVectorTypes.SimpleSetTest. When 32 isn’t present and all elements are <32, lower_bound(32) legitimately returns end(). The test immediately did if (*it == 32), which dereferences an end iterator, causing UB. Added a guard it == s2.end() before dereferencing. There was also flakiness if 32 is present and if s2.lower_bound(32); returned a lower value than 32 as then 32 not erased. Fixed by explicity erasing 32 before insert Differential Revision: D88592733
Summary: Fix the cmake tests when jemalloc is found memory_mallctl_helper_test wasn't linking to jemalloc when jemalloc was found so no way mallctl could work Also link the string test to jemalloc if found as it has a check for it Differential Revision: D88594886
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary:
Fix the cmake tests when jemalloc is found
memory_mallctl_helper_test wasn't linking to jemalloc when jemalloc was found so no way mallctl could work
Also link the string test to jemalloc if found as it has a check for it
Differential Revision: D88594886