test: Isolate fixture repositories from global git configuration - #88
Open
chucklever wants to merge 1 commit into
Open
chucklever wants to merge 1 commit into
chucklever wants to merge 1 commit into
Conversation
The test helpers that shell out to git pin author and committer identity through the environment but leave configuration inherited, so a fixture repository behaves differently depending on who runs the suite. With tag.gpgSign set, the bare `git tag v1` in create_merge_repo() becomes a signed annotated tag and fails for want of a message. All three list_shas_in_range tests then abort during fixture setup. A commit.gpgSign or gpg.format setting breaks every other fixture the same way, at its first `git commit`. Point GIT_CONFIG_GLOBAL and GIT_CONFIG_SYSTEM at /dev/null in every git shell-out under src/ and tests/ so a fixture sees only the repository it creates. Fixes: 636e4ea ("test: add regression tests for list_shas_in_range with merge topology") Signed-off-by: Chuck Lever <cel@kernel.org>
meta-cla
Bot
added
the
CLA Signed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The test helpers that shell out to git pin author and committer identity through the environment but leave configuration inherited, so a fixture repository behaves differently depending on who runs the suite. With
tag.gpgSignset, the baregit tag v1increate_merge_repo()becomes a signed annotated tag and fails for want of a message. All threelist_shas_in_rangetests then abort during fixture setup. Acommit.gpgSignorgpg.formatsetting breaks every other fixture the same way, at its firstgit commit.Point
GIT_CONFIG_GLOBALandGIT_CONFIG_SYSTEMat/dev/nullin every git shell-out undersrc/andtests/so a fixture sees only the repository it creates.