Fix float32 auto-conversion - #253
Conversation
|
Hi @murlock1000! Thank you for your pull request and welcome to our community. Action RequiredIn order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks! |
|
Just a heads-up that the PR is showing the following below when using So you have to fix the |
Fixes #39
On RTX 4090 GPU the model code auto-converted aggregated and patch tokens to torch.float32 dtype, even though bfloat16/float16 was specified. This lead to twice the amount of memory being used on the GPU. This fix prevents the auto-conversion providing memory performance as stated in the paper.