Skip to content

Add opencmw source block and rda3 client - #199

Merged
RalphSteinhagen merged 1 commit into
mainfrom
opencmwSource
Mar 19, 2026
Merged

Add opencmw source block and rda3 client#199
RalphSteinhagen merged 1 commit into
mainfrom
opencmwSource

Add opencmw source block and rda3 client

4a0a949
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 19, 2026 in 3m 18s

Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 80%)
21.7% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

Annotations

Check warning on line 34 in blocklib/opencmw/include/fair/opencmw/cmwlight/CmwLightClient.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent comparator "std::less<>" with this associative string container. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZ0BIqNv5kapvCtdkyXE&open=AZ0BIqNv5kapvCtdkyXE&pullRequest=199

Check warning on line 197 in blocklib/opencmw/test/qa_OpenCmwClient.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 76 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZ0BIqNF5kapvCtdkyW_&open=AZ0BIqNF5kapvCtdkyW_&pullRequest=199

Check warning on line 87 in blocklib/opencmw/include/fair/opencmw/cmwlight/CmwLightClient.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent comparator "std::less<>" with this associative string container. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZzTFFL8ZHWxYYhb8yX0&open=AZzTFFL8ZHWxYYhb8yX0&pullRequest=199

Check warning on line 16 in blocklib/opencmw/test/qa_OpenCmwSource.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 68 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZzTFFIYZHWxYYhb8yXk&open=AZzTFFIYZHWxYYhb8yXk&pullRequest=199

Check failure on line 129 in blocklib/opencmw/include/fair/opencmw/OpenCmwSource.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 27 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZ0BIqN85kapvCtdkyXM&open=AZ0BIqN85kapvCtdkyXM&pullRequest=199

Check warning on line 772 in blocklib/opencmw/include/fair/opencmw/cmwlight/CmwLightClient.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent equality "std::equal_to<>" and a custom transparent heterogeneous hasher with this associative string container. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZzTFFL8ZHWxYYhb8yYJ&open=AZzTFFL8ZHWxYYhb8yYJ&pullRequest=199

Check warning on line 76 in blocklib/opencmw/include/fair/opencmw/OpenCmwSource.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "insert" with "try_emplace". 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZ0BIqN85kapvCtdkyXI&open=AZ0BIqN85kapvCtdkyXI&pullRequest=199

Check failure on line 609 in blocklib/opencmw/include/fair/opencmw/cmwlight/CmwLightClient.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 109 to the 25 allowed. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZzTFFL8ZHWxYYhb8yYD&open=AZzTFFL8ZHWxYYhb8yYD&pullRequest=199

Check warning on line 818 in blocklib/opencmw/include/fair/opencmw/cmwlight/CmwLightClient.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this variable a reference-to-const. The current type of this unnamed variable is "struct std::pair<const class std::basic_string<char>, struct opencmw::client::cmwlight::Subscription> &". 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZzTFFL8ZHWxYYhb8yYO&open=AZzTFFL8ZHWxYYhb8yYO&pullRequest=199

Check warning on line 43 in blocklib/opencmw/include/fair/opencmw/cmwlight/CmwLightClient.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent comparator "std::less<>" with this associative string container. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZzTFFL8ZHWxYYhb8yXy&open=AZzTFFL8ZHWxYYhb8yXy&pullRequest=199

Check warning on line 314 in blocklib/opencmw/include/fair/opencmw/cmwlight/CmwLightClient.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define and throw a dedicated exception instead of using a generic one. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZzTFFL8ZHWxYYhb8yX6&open=AZzTFFL8ZHWxYYhb8yX6&pullRequest=199

Check failure on line 902 in blocklib/opencmw/include/fair/opencmw/cmwlight/CmwLightClient.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZzTFFL8ZHWxYYhb8yYY&open=AZzTFFL8ZHWxYYhb8yYY&pullRequest=199

Check warning on line 90 in blocklib/opencmw/include/fair/opencmw/OpenCmwSource.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "push" with "emplace". 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZ0BIqN85kapvCtdkyXL&open=AZ0BIqN85kapvCtdkyXL&pullRequest=199

Check warning on line 59 in blocklib/opencmw/test/qa_OpenCmwClient.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 407 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZzTFFKuZHWxYYhb8yXm&open=AZzTFFKuZHWxYYhb8yXm&pullRequest=199

Check warning on line 863 in blocklib/opencmw/include/fair/opencmw/cmwlight/CmwLightClient.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define and throw a dedicated exception instead of using a generic one. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZzTFFL8ZHWxYYhb8yYS&open=AZzTFFL8ZHWxYYhb8yYS&pullRequest=199

Check warning on line 579 in blocklib/opencmw/include/fair/opencmw/cmwlight/CmwLightClient.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define and throw a dedicated exception instead of using a generic one. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZzTFFL8ZHWxYYhb8yYA&open=AZzTFFL8ZHWxYYhb8yYA&pullRequest=199

Check failure on line 20 in blocklib/opencmw/test/ProcessHelper.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

const_cast removing const qualification from the type of a pointer may lead to an undefined behaviour. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZ0BIqNP5kapvCtdkyXD&open=AZ0BIqNP5kapvCtdkyXD&pullRequest=199

Check warning on line 145 in blocklib/opencmw/include/fair/opencmw/OpenCmwSource.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace with the version of "std::ranges::copy" that takes a range. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZ0BIqN85kapvCtdkyXP&open=AZ0BIqN85kapvCtdkyXP&pullRequest=199

Check warning on line 71 in blocklib/opencmw/test/qa_OpenCmwClient.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

This lambda has 22 lines, which is greater than the 20 lines authorized. Split it into several lambdas or functions, or make it a named function. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZzTFFKuZHWxYYhb8yXn&open=AZzTFFKuZHWxYYhb8yXn&pullRequest=199

Check warning on line 405 in blocklib/opencmw/include/fair/opencmw/cmwlight/CmwLightClient.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define and throw a dedicated exception instead of using a generic one. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZzTFFL8ZHWxYYhb8yX7&open=AZzTFFL8ZHWxYYhb8yX7&pullRequest=199

Check warning on line 827 in blocklib/opencmw/include/fair/opencmw/cmwlight/CmwLightClient.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this empty statement. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZzTFFL8ZHWxYYhb8yYN&open=AZzTFFL8ZHWxYYhb8yYN&pullRequest=199

Check failure on line 135 in blocklib/opencmw/include/fair/opencmw/OpenCmwSource.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this code to not nest more than 3 if|for|do|while|switch statements. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZ0BIqN85kapvCtdkyXN&open=AZ0BIqN85kapvCtdkyXN&pullRequest=199

Check warning on line 566 in blocklib/opencmw/include/fair/opencmw/cmwlight/CmwLightClient.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Define and throw a dedicated exception instead of using a generic one. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZzTFFL8ZHWxYYhb8yX_&open=AZzTFFL8ZHWxYYhb8yX_&pullRequest=199

Check warning on line 807 in blocklib/opencmw/include/fair/opencmw/cmwlight/CmwLightClient.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Reduce verbosity with "using enum" for "opencmw::mdp::Command". 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZzTFFL8ZHWxYYhb8yYM&open=AZzTFFL8ZHWxYYhb8yYM&pullRequest=199

Check warning on line 412 in blocklib/opencmw/test/qa_OpenCmwClient.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove this redundant temporary object by constructing "std::string_view" directly. 

See more on https://sonarcloud.io/project/issues?id=fair-acc_gr-digitizers&issues=AZzTFFKuZHWxYYhb8yXr&open=AZzTFFKuZHWxYYhb8yXr&pullRequest=199
View more details on SonarQubeCloud