Skip to content

Serialiser and Zeromq changes to support rda3 client implementation - #348

Merged
RalphSteinhagen merged 5 commits into
mainfrom
rda3
Mar 19, 2026
Merged

Serialiser and Zeromq changes to support rda3 client implementation#348
RalphSteinhagen merged 5 commits into
mainfrom
rda3

Zeromq message format: add utilities

382d5c2
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis failed Mar 19, 2026 in 13m 45s

Quality Gate failed

Annotations

Check warning on line 61 in src/serialiser/test/IoSerialiserCmwLight_tests.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent comparator "std::less<>" with this associative string container.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZx8aoVna6TmzXSb9FFp&open=AZx8aoVna6TmzXSb9FFp&pullRequest=348

Check warning on line 548 in src/serialiser/include/IoSerialiserJson.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent comparator "std::less<>" with this associative string container.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZx8aoV-a6TmzXSb9FF3&open=AZx8aoV-a6TmzXSb9FF3&pullRequest=348

Check failure on line 139 in src/serialiser/include/IoSerialiserCmwLight.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 46 to the 25 allowed.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZx8aoWLa6TmzXSb9FF4&open=AZx8aoWLa6TmzXSb9FF4&pullRequest=348

Check failure on line 238 in src/zmq/include/zmq/ZmqUtils.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZx8aoXea6TmzXSb9FGC&open=AZx8aoXea6TmzXSb9FGC&pullRequest=348

Check warning on line 350 in src/serialiser/include/IoSerialiserCmwLight.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a reference-to-const. The current type of "buffer" is "struct opencmw::IoBuffer &".

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZx8aoWLa6TmzXSb9FF6&open=AZx8aoWLa6TmzXSb9FF6&pullRequest=348

Check failure on line 235 in src/zmq/include/zmq/ZmqUtils.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace the use of "new" with an operation that automatically manages the memory.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZx8aoXea6TmzXSb9FGA&open=AZx8aoXea6TmzXSb9FGA&pullRequest=348

Check warning on line 36 in src/serialiser/test/IoSerialiserCmwLight_tests.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent comparator "std::less<>" with this associative string container.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZx8aoVna6TmzXSb9FFn&open=AZx8aoVna6TmzXSb9FFn&pullRequest=348

Check warning on line 481 in src/serialiser/include/IoSerialiserCmwLight.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "requestedType" inside the if statement.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZ0FVrb0Qsj-WQT-cXSe&open=AZ0FVrb0Qsj-WQT-cXSe&pullRequest=348

Check warning on line 188 in src/serialiser/test/IoSerialiserCmwLight_tests.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZx8aoVna6TmzXSb9FFm&open=AZx8aoVna6TmzXSb9FFm&pullRequest=348

Check warning on line 368 in src/serialiser/test/IoSerialiserCmwLight_tests.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent comparator "std::less<>" with this associative string container.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZx8aoVna6TmzXSb9FFv&open=AZx8aoVna6TmzXSb9FFv&pullRequest=348

Check warning on line 364 in src/serialiser/test/IoSerialiserCmwLight_tests.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent comparator "std::less<>" with this associative string container.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZx8aoVna6TmzXSb9FFu&open=AZx8aoVna6TmzXSb9FFu&pullRequest=348

Check warning on line 339 in src/serialiser/test/IoSerialiserCmwLight_tests.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent comparator "std::less<>" with this associative string container.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZx8aoVna6TmzXSb9FFt&open=AZx8aoVna6TmzXSb9FFt&pullRequest=348

Check warning on line 462 in src/serialiser/include/IoSerialiserCmwLight.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

"catch" a specific exception type.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZyfN812U3LdkwC6C7XO&open=AZyfN812U3LdkwC6C7XO&pullRequest=348

Check warning on line 620 in src/serialiser/include/IoSerialiserJson.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Complete the task associated to this "TODO" comment.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZx8aoV-a6TmzXSb9FF2&open=AZx8aoV-a6TmzXSb9FF2&pullRequest=348

Check failure on line 411 in src/serialiser/include/IoSerialiserCmwLight.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Explicitly capture the required scope variables.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZ0FVrb0Qsj-WQT-cXSd&open=AZ0FVrb0Qsj-WQT-cXSd&pullRequest=348

Check warning on line 302 in src/serialiser/test/IoSerialiserCmwLight_tests.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent comparator "std::less<>" with this associative string container.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZx8aoVna6TmzXSb9FFr&open=AZx8aoVna6TmzXSb9FFr&pullRequest=348

Check warning on line 258 in src/serialiser/include/IoSerialiserCmwLight.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Make the type of this parameter a reference-to-const. The current type of "buffer" is "struct opencmw::IoBuffer &".

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZx8aoWLa6TmzXSb9FF5&open=AZx8aoWLa6TmzXSb9FF5&pullRequest=348

Check failure on line 238 in src/zmq/include/zmq/ZmqUtils.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Replace this use of "void *" with a more meaningful type.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZx8aoXea6TmzXSb9FGD&open=AZx8aoXea6TmzXSb9FGD&pullRequest=348

Check warning on line 432 in src/serialiser/include/IoSerialiserCmwLight.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent comparator "std::less<>" with this associative string container.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZx8aoWLa6TmzXSb9FF9&open=AZx8aoWLa6TmzXSb9FF9&pullRequest=348

Check failure on line 239 in src/zmq/include/zmq/ZmqUtils.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rewrite the code so that you no longer need this "delete".

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZx8aoXea6TmzXSb9FGB&open=AZx8aoXea6TmzXSb9FGB&pullRequest=348

Check failure on line 130 in src/core/include/SpinWait.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use 'std::memory_order::seq_cst' (or remove this argument to use its default value) to ensure sequential consistency.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZ0FVrcxQsj-WQT-cXSh&open=AZ0FVrcxQsj-WQT-cXSh&pullRequest=348

Check warning on line 47 in src/serialiser/test/IoSerialiserCmwLight_tests.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent comparator "std::less<>" with this associative string container.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZx8aoVna6TmzXSb9FFo&open=AZx8aoVna6TmzXSb9FFo&pullRequest=348

Check warning on line 448 in src/serialiser/include/IoSerialiserCmwLight.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the transparent comparator "std::less<>" with this associative string container.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZyWf_c2uLk3cp316Nhm&open=AZyWf_c2uLk3cp316Nhm&pullRequest=348

Check warning on line 349 in src/serialiser/include/IoSerialiser.hpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the init-statement to declare "requestedType" inside the if statement.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZ0FVrcTQsj-WQT-cXSf&open=AZ0FVrcTQsj-WQT-cXSf&pullRequest=348

Check warning on line 353 in src/serialiser/test/IoSerialiserCmwLight_tests.cpp

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the commented out code.

See more on https://sonarcloud.io/project/issues?id=fair-acc_opencmw-cpp&issues=AZ0FVrbFQsj-WQT-cXSc&open=AZ0FVrbFQsj-WQT-cXSc&pullRequest=348