Release 0.1.3 - #94
Merged
Merged
Conversation
Google writes are the reason for this one. Gmail moves to gmail.modify and Calendar picks up calendar.events, so every Google connection reconnects once. GitHub gained review replies, api keys are checked before they are stored, and a Google 403 caused by a missing scope finally says reconnect.
calendar.events already covers all six event tools, reads included, because
they all go through /calendars/{id}/events. The one call outside that is
list_calendars on /users/me/calendarList, and calendar.calendarlist.readonly
is exactly that and nothing more.
calendar.readonly covered both, which is why it was there. It also grants
"See and download any calendar you can access" to satisfy one list call, and
the Google consent screen asks in writing why a narrower scope will not do.
For this one it will.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cuts a tag so the gateway has something to deploy. The deploy takes the highest
v*tag, never a branch, so main sitting ahead ofv0.1.2means the box has been running without the Google writes since 23 Aug.The scope change is the part that affects people. Gmail goes from
gmail.readonlytogmail.modify, Calendar addscalendar.events, and both mean every existing Google connection re-consents once. Drive was already at the full scope inv0.1.2.That also settles what goes on the Google consent screen's Data access page, which is currently empty:
npm test: 459 passed.