Conversation
Signed-off-by: lprnmns <manasalperen@gmail.com>
There was a problem hiding this comment.
🟢 Approval recommended
The focused fix correctly restores documented encoding behavior with regression coverage.
Pull request overview
Fixes custom cookie encoders by forwarding serialization options to cookie@2.
Changes:
- Passes options to
stringifySetCookie. - Adds regression coverage for
reply.setCookie()encoding.
File summaries
| File | Description |
|---|---|
index.js |
Forwards serializer options. |
test/cookie.test.js |
Verifies custom encoding. |
Review details
- Files reviewed: 2/2 changed files
- Comments generated: 0
- Review effort level: Balanced
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
After the cookie@2 migration, a custom encode function passed to reply.setCookie() or the serializer decorator is ignored. The resulting Set-Cookie value is emitted without the caller's encoder, despite encode being a documented cookie serialization option.
Fix
Forward the existing options object as cookie@2's serializer-options argument so its encode function is applied. Calls without encode retain their current output.
Tests
Compatibility
The public API signature is unchanged. Existing calls without a custom encoder produce the same serialization; calls with encode now honor the documented option. The change adds no dependency or lockfile updates.
Related issue
Independent reproduction. No currently open issue or competing pull request for this behavior was found.