Export screenshots#5
Draft
ainame wants to merge 24 commits into
Draft
Conversation
e0d13c2 to
ad5a1a5
Compare
ainame
commented
Jul 23, 2021
| class ExportOptions | ||
| AVAILABLE_OPTIONS = %i[destination by_device by_locale].freeze | ||
|
|
||
| def initialize(**options) |
9c39a1e to
c4a4bb0
Compare
157ab94 to
c4a4bb0
Compare
c4a4bb0 to
4a6ed0d
Compare
4a6ed0d to
a4f5dcb
Compare
|
Hi, when I was testing this PR, I confronted a crash during the screenshot export. Some tests don't have attachments = action_testable_summary.all_tests
.map(&:summary_ref)
.map { |ref| ref.load_object(from: path) }
.flat_map(&:activity_summaries)
.flat_map(&:subactivities)
.flat_map(&:attachments)I have solved this issue by using a select before the map attachments = action_testable_summary.all_tests.select {|x| x.summary_ref } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR depends on changes in #4 so this PR includes many unnecessary changes at this moment.
You can see actual changes on this PR is here ainame/xcresult@generate-models...ainame:export-screenshots.
Prior to this PR, I've also submitted the PR that powers this gem to cover all the models that
.xcresultfile format uses. This PR implemented exporting of screenshots functionality.Additionally, I added
bin/consoleandbin/setupwhich are normally bundled with a newly created gem bybundler. It is very handy for basic debugging, like runningXCResult::Parser.new(path: '...')locally.